Cleanup scrubber wont list all images

Bug #1280343 reported by Tom Hancock
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Medium
Eddie Sheffield

Bug Description

The cleanup scrubber would never list more than one batch of images
from the registry if the registry were to truncate the number of images
returned to its (the registry's) max limit.

It should be updated to access the image list iteratively using a marker.

Zhi Yan Liu (lzy-dev)
Changed in glance:
importance: Undecided → Medium
Feilong Wang (flwang)
Changed in glance:
status: New → Triaged
Changed in glance:
assignee: nobody → Eddie Sheffield (eddie-sheffield)
Changed in glance:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/128142

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/128142
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=d4658117e394971661b15b4bce8ecd3a4e1e5b8f
Submitter: Jenkins
Branch: master

commit d4658117e394971661b15b4bce8ecd3a4e1e5b8f
Author: Eddie Sheffield <email address hidden>
Date: Mon Oct 13 20:07:36 2014 -0400

    Glance scrubber should page thru images from registry

    If the registry is limited in it's page size when returning the
    list of images, the scrubber will only receive the first page.
    This patch enables the scrubber to retrieve all the pages of
    images.

    The new tests are implemented with mock rather than mox. There
    is another patch (https://review.openstack.org/#/c/111995) to
    convert the existing code in test_scrubber to use mock.

    Change-Id: I106f679be96bd39167337c4e27f4046f90d7d7ff
    Closes-Bug: 1280343

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: kilo-1 → 2015.1.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on glance (master)

Change abandoned by Flavio Percoco (<email address hidden>) on branch: master
Review: https://review.openstack.org/73627
Reason: after all this time, I'd assume we don't need this patch anymore. The bug/blueprint was probably fixed already or invalidated. Please, feel free to re-open it if you think otherwise.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.