Glance v1 unit test code can do with some refactoring

[David Koo]

The Glance v1 unit test code (tests/unit/v1/test_api.py) can do with some refactoring - there are lots of repeated patterns throughout the code. Refactoring it can help with understanding and maintaining the code and also make adding future tests simpler.

This bug is an action item to track the review comment for https://review.openstack.org/#/c/64079/4 raised by Steve Kowalik.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/87020

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/92193

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/92218

[OpenStack Infra (hudson-openstack)]

Change abandoned by Flavio Percoco (<email address hidden>) on branch: master
Review: https://review.openstack.org/87020
Reason: after all this time, I'd assume we don't need this patch anymore. The bug/blueprint was probably fixed already or invalidated. Please, feel free to re-open it if you think otherwise.

[Abhishek Kekane (abhishek-kekane)]

V1 tests has been removed in rocky cycle, no need to act on this anymore.