remove, add and save in glance.db.__init__ should not return

Bug #1254210 reported by Nikhil Komawar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Low
Jia Dong

Bug Description

add and save method in ImageMemberRepo are returning a new object. It is expected to modify the values in-place rather than adding them in the new object.

Changed in glance:
status: New → Triaged
importance: Undecided → Low
Changed in glance:
assignee: nobody → nikhil komawar (nikhil-komawar)
Changed in glance:
assignee: nikhil komawar (nikhil-komawar) → nobody
Jia Dong (jiadong-jia)
Changed in glance:
assignee: nobody → Jia Dong (jiadong-jia)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/63348

Changed in glance:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/63348
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=1772a9116d127294354addd830e16877658bbee3
Submitter: Jenkins
Branch: master

commit 1772a9116d127294354addd830e16877658bbee3
Author: Jia Dong <email address hidden>
Date: Fri Dec 20 15:37:25 2013 +0800

    Remove return stmt of add,save and remove method

    Remove the add and save method's return statement in the
    ImageMemberRepo class, as the same as ImageRepo class. Also
    modify authorization.py and policy.py and the related unittest.

    Closes-Bug: #1254210

    Change-Id: I472cd15af8648beea10abc595e905618091f3dab

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.