core domain objects depend on config

Bug #1250633 reported by Mark Washenberger
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Low
Jia Dong

Bug Description

The core of the domain model should be as dependency free as possible.

However, since 830f27ba342ca0881e3677ac11c3d818962cba3e (change id Ic52ffb46df9438c247ba063748cadd69b9c90bcd) we have depended on configuration in glance.domain.__init__.

This configuration should instead be depended on in the infrastructure (probably in glance.gateway) and passed in as an initialization parameter to the domain model objects.

Changed in glance:
importance: Undecided → Low
status: New → Triaged
Jia Dong (jiadong-jia)
Changed in glance:
assignee: nobody → Jia Dong (jiadong-jia)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/64243

Changed in glance:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/64243
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=f035efd043aa75d662d2a26a963358db59b75628
Submitter: Jenkins
Branch: master

commit f035efd043aa75d662d2a26a963358db59b75628
Author: Jia Dong <email address hidden>
Date: Fri Dec 27 16:33:41 2013 +0800

    Decouple the config dependence on glance domain

    Move the configurations which core domain objects depend on to
    common/config.py, and add a argument "task_time_to_live" of Task's
     __init__ method and TaskFactory's new_task method for delivering
    the CONF.task.task_time_to_live value.
    For convenience,the argument "task_time_to_live" is set a default value 48.

    Change-Id: Iffda1ecd25470824c812d66a27fa64ebbaabcf07
    Closes-Bug: #1250633

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.