Simple db incorrectly treats image tags as part of the core image entity

[Alex Meade]

Simple db treats image tags as a core attribute of images. image tags should not be returned as part of an image nor set when calling db_api.image_create. Since simple db has allowed this, many tests have incorrectly been treating tags as a core attribute.

Fixing this and the tests is a prerequisite for finishing blueprint remove-simple-driver since the sqlalchemy driver does not allow setting tags this way and the tests currently depend on it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/55100

[Erno Kuvaja (jokke)]

Old and abandoned, possibly fixed.

[Ian Cordasco (icordasc)]

This doesn't appear to have been fixed. Looking at review 55100 that was proposed by Alex,

https://github.com/openstack/glance/blob/3445866403b2076a576838dbaabd1541a66cb426/glance/db/simple/api.py#L217 and https://github.com/openstack/glance/blob/3445866403b2076a576838dbaabd1541a66cb426/glance/db/simple/api.py#L294..312 it doesn't appear to have changed very much or have been fixed. This should be confirmed as still being an issue before closing or prioritizing it though.

[Ian Cordasco (icordasc)]

So this wasn't exactly a bug (upon further research). This was part of https://blueprints.launchpad.net/glance/+spec/remove-simple-driver which hasn't been accepted or updated and which markwash rejected. The status is still new so I've added it to the next meeting agenda to make sure it's seen before outright rejecting this bug.