Use self.assertTrue instead of self.assertEqual(..., True)

[Arnaud Legendre]

$ find . -name '*.*' | xargs grep self.assertEqual | grep True

./tests/integration/legacy_functional/test_v1_api.py: self.assertEqual(data['image']['is_public'], True)
./tests/integration/legacy_functional/test_v1_api.py: self.assertEqual(data['image']['is_public'], True)
./tests/integration/legacy_functional/test_v1_api.py: self.assertEqual(data['image']['is_public'], True)
./tests/integration/legacy_functional/test_v1_api.py: self.assertEqual(response['x-image-meta-is_public'], 'True')
./tests/integration/legacy_functional/test_v1_api.py: self.assertEqual(data['image']['is_public'], True)
./tests/integration/legacy_functional/test_v1_api.py: self.assertEqual(data['image']['is_public'], True)
./tests/integration/legacy_functional/test_v1_api.py: self.assertEqual(data['image']['is_public'], True)
...
./tests/unit/test_swift_store.py: self.assertEqual(connection.insecure, True)
./tests/unit/test_swift_store.py: self.assertEquals(connection.snet, True)
./tests/unit/test_swift_store.py: self.assertEquals(connection.snet, True)

$ find . -name '*.*' | xargs grep self.assertTrue
./tests/unit/test_context_middleware.py: self.assertTrue(req.context.is_admin)
./tests/unit/test_context_middleware.py: self.assertTrue(req.context.is_admin)
...
./tests/unit/test_context_middleware.py: self.assertTrue(req.context.is_admin)
./tests/unit/test_context_middleware.py: self.assertTrue(req.context.read_only)
./tests/unit/test_context_middleware.py: self.assertTrue(req.context.is_admin)

The tests assertions need to be consistent: use assertTrue/assertFalse instead of assertEqual to test boolean values.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/49286

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/53257

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/53968

[Bartosz Fic (bartosz-fic)]

Hi, What is the current status of this bug ? This code has negative reviews and has been abandoned. Also Jenkins failed. Is anybody working on this ?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/121030

[Bartosz Fic (bartosz-fic)]

Hey,
I have written a code which resolves this bug in 11 files. Feel free to review :)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/121030
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=0b246bb5f561d694a4fa4f41c90811a64c05b9fb
Submitter: Jenkins
Branch: master

commit 0b246bb5f561d694a4fa4f41c90811a64c05b9fb
Author: Bartosz Fic <email address hidden>
Date: Fri Sep 12 10:49:16 2014 +0200

    Replaces assertEqual with assertTrue and assertFalse

    In order to improve coding practices and be aligned to a standard,
    self.assertEqual(...,True) statements where replaced with
    self.assertTrue and self.assertFalse.

    Change-Id: I4150a343493beae03d6f71c88e84f60d14fb60e1
    Closes-Bug: #1230127