allow sorting with more than one field

Bug #1221274 reported by Dafna Ron
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
High
Mike Fedosin
Glance Client
High
Unassigned

Bug Description

when running glance image-list --sort-key we only get to use one sort field.
it would be helpful if I was able to sort with more than one field (as in, first name, than size, than status).

Revision history for this message
Feilong Wang (flwang) wrote :

Thanks for reporting this. My initial thought is we can use comma as separator to support passing in multi sort_key.

Changed in glance:
assignee: nobody → Fei Long Wang (flwang)
status: New → In Progress
Feilong Wang (flwang)
Changed in glance:
assignee: Fei Long Wang (flwang) → nobody
status: In Progress → Triaged
tags: added: low-hanging-fruit
Haojie Jia (jiahaojie)
Changed in glance:
assignee: nobody → Haojie Jia (jiahaojie)
Revision history for this message
Feilong Wang (flwang) wrote :

Seems current owner doesn't have much bandwidth on this. I'm assigning it to volunteer.

Changed in glance:
assignee: Haojie Jia (jiahaojie) → nobody
assignee: nobody → Mike Fedosin (mfedosin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/120727

Changed in glance:
status: Triaged → In Progress
Ian Cordasco (icordasc)
Changed in glance:
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/120727
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=2c3e3656b02a6f26c9fe98e95be103fe48015ae7
Submitter: Jenkins
Branch: master

commit 2c3e3656b02a6f26c9fe98e95be103fe48015ae7
Author: Mike Fedosin <email address hidden>
Date: Thu Sep 11 13:08:30 2014 +0400

    Adds the ability to sort images with multiple keys

    Extend rest api v2 with multiple sort keys support.
    Example:
    /v2/images/detail?sort_key=name&sort_key=size
    Changed database api which now takes sort_key param as a list instead of string
    python-glanceclient support will be added in separate commit

    Change-Id: Ib7a6aeb2df3bc5d23fe8e070290b5bfcab00c0f5
    DocImpact
    Partial-Bug: 1221274

Changed in glance:
milestone: none → kilo-2
importance: Wishlist → High
Revision history for this message
Ian Cordasco (icordasc) wrote :
Revision history for this message
Nikhil Komawar (nikhil-komawar) wrote :

Thanks Ian, we are waiting for that to merged.

Glad that you linked the spec here!

We don't have to do this enhancement until the spec has merged.

Thierry Carrez (ttx)
Changed in glance:
milestone: kilo-2 → kilo-3
Revision history for this message
Zhi Yan Liu (lzy-dev) wrote :

Can we close this defect now? the spec has been merged, beside change #120727, does glance needs any more change?

Revision history for this message
Zhi Yan Liu (lzy-dev) wrote :

If there's no any other changes, we're going to close this defect as 'done'.

Revision history for this message
Mike Fedosin (mfedosin) wrote :

Hi! Unfortunately there is a client side commit that hasn't been merged yet https://review.openstack.org/#/c/120777/ . Before it's done this bug shouldn't be marked as closed.

Thierry Carrez (ttx)
Changed in glance:
milestone: kilo-3 → kilo-rc1
Revision history for this message
Nikhil Komawar (nikhil-komawar) wrote :

Glance change was merge in kilo-3

Glance client change is in tag 0.17.0

Changed in glance:
status: In Progress → Fix Committed
Changed in python-glanceclient:
status: New → Fix Released
importance: Undecided → High
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Related blueprints