UserWarning on deprecation of legacy glance client inappropriate for internal usage

Bug #1129445 reported by Eoghan Glynn on 2013-02-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Low
Eoghan Glynn
Folsom
Low
Eoghan Glynn

Bug Description

Presumably the UserWarning on import of the legacy glance client was only intended as a signal to "external" usages of this deprecated library.

For internal usage such as the glance-cache-manage utility, this is exposing internal technical debt as an apparent user-facing warning, which seems inappropriate:

  /usr/bin/glance-cache-manage:40: UserWarning: The 'glance.client' module is deprecated in favor of the 'glanceclient' module provided by python-glanceclient (see http://github.com/openstack/python-glanceclient).

Instead, the warning should be swallowed by glance-cache-manage.

Fix proposed to branch: master
Review: https://review.openstack.org/22236

Changed in glance:
status: New → In Progress
Eoghan Glynn (eglynn) on 2013-02-18
Changed in glance:
importance: Undecided → Low
assignee: nobody → Eoghan Glynn (eglynn)
milestone: none → grizzly-3
Eoghan Glynn (eglynn) wrote :

It turns out this issue is only relevant on stable/folsom (as opposed to master).

Brian Waldon (bcwaldon) on 2013-02-20
Changed in glance:
milestone: grizzly-3 → none

Reviewed: https://review.openstack.org/22305
Committed: http://github.com/openstack/glance/commit/12d28c36983ee066a1b62fc66f9fc396a1405fa7
Submitter: Jenkins
Branch: stable/folsom

commit 12d28c36983ee066a1b62fc66f9fc396a1405fa7
Author: Eoghan Glynn <email address hidden>
Date: Tue Feb 19 11:36:38 2013 +0000

    Swallow UserWarning from glance-cache-manage

    Fixes bug 1129445

    Previously, we exposed internal technical debt as an apparent
    user-facing warning.

    Now the warning is swallowed in the internal case, but continues
    to be seen by external users of this library.

    Note that this fix is not relevant on master, as that the warning
    no longer occurs in that case.

    Change-Id: I30a835e0024acac8841b4746968abe7cae9e14cb

tags: added: in-stable-folsom
Alan Pevec (apevec) on 2013-03-27
Changed in glance:
status: In Progress → Invalid
Alan Pevec (apevec) on 2013-04-05
tags: removed: in-stable-folsom
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers