UserWarning on deprecation of legacy glance client inappropriate for internal usage

[Eoghan Glynn]

Presumably the UserWarning on import of the legacy glance client was only intended as a signal to "external" usages of this deprecated library.

For internal usage such as the glance-cache-manage utility, this is exposing internal technical debt as an apparent user-facing warning, which seems inappropriate:

  /usr/bin/glance-cache-manage:40: UserWarning: The 'glance.client' module is deprecated in favor of the 'glanceclient' module provided by python-glanceclient (see http://github.com/openstack/python-glanceclient).

Instead, the warning should be swallowed by glance-cache-manage.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/22236

[Eoghan Glynn (eglynn)]

It turns out this issue is only relevant on stable/folsom (as opposed to master).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/22305

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/22305
Committed: http://github.com/openstack/glance/commit/12d28c36983ee066a1b62fc66f9fc396a1405fa7
Submitter: Jenkins
Branch: stable/folsom

commit 12d28c36983ee066a1b62fc66f9fc396a1405fa7
Author: Eoghan Glynn <email address hidden>
Date: Tue Feb 19 11:36:38 2013 +0000

    Swallow UserWarning from glance-cache-manage

    Fixes bug 1129445

    Previously, we exposed internal technical debt as an apparent
    user-facing warning.

    Now the warning is swallowed in the internal case, but continues
    to be seen by external users of this library.

    Note that this fix is not relevant on master, as that the warning
    no longer occurs in that case.

    Change-Id: I30a835e0024acac8841b4746968abe7cae9e14cb