OpenStack Image Registry and Delivery Service (Glance)

filesystem store does not clean up after premature termination of image upload

Reported by Eoghan Glynn on 2013-01-25
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Medium
Eoghan Glynn
Folsom
Medium
Eoghan Glynn
Grizzly
Medium
Eoghan Glynn

Bug Description

If a PUT or POST of image content is terminated prematurely by the client, the image is marked as killed.

In the case of swift and s3, such partial uploads are properly cleaned up and do not leave behind dangling image fragments visible in store.

However this is not the case for the filesystem store, where the partially saved image file is left behind in the data directory.

Eoghan Glynn (eglynn) on 2013-01-25
Changed in ceilometer:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → grizzly-3
assignee: nobody → Eoghan Glynn (eglynn)
status: Confirmed → In Progress
Eoghan Glynn (eglynn) on 2013-01-25
affects: ceilometer → glance
Changed in glance:
milestone: grizzly-3 → none
milestone: none → grizzly-3
Eoghan Glynn (eglynn) on 2013-01-25
tags: added: folsom-backport-potential
Mark McLoughlin (markmc) on 2013-01-25
tags: removed: folsom-backport-potential

Reviewed: https://review.openstack.org/20472
Committed: http://github.com/openstack/glance/commit/0756cf10252df868c6470771cbc9c7aeb081c062
Submitter: Jenkins
Branch: master

commit 0756cf10252df868c6470771cbc9c7aeb081c062
Author: Eoghan Glynn <email address hidden>
Date: Fri Jan 25 13:18:58 2013 +0000

    Clean dangling image fragments in filesystem store

    Fixes bug LP 1104924

    Previously when a PUT or POST of image content was terminated
    prematurely by the client, the partially saved image file was
    left behind in the data directory.

    Change-Id: Id601816735e4138cd7623dad4d90be67448292c8

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-02-21
Changed in glance:
status: Fix Committed → Fix Released

Reviewed: https://review.openstack.org/20481
Committed: http://github.com/openstack/glance/commit/5183360f4c308131adde13535af0f11ccd3b1462
Submitter: Jenkins
Branch: stable/folsom

commit 5183360f4c308131adde13535af0f11ccd3b1462
Author: Eoghan Glynn <email address hidden>
Date: Fri Jan 25 13:18:58 2013 +0000

    Clean dangling image fragments in filesystem store

    Fixes bug LP 1104924

    Previously when a PUT or POST of image content was terminated
    prematurely by the client, the partially saved image file was
    left behind in the data directory.

    Change-Id: Id601816735e4138cd7623dad4d90be67448292c8

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers