Glance

Latest json-patch draft (10) is incompatibile with Images API v2 implementation

Bug #1102476 reported by Brian Waldon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Critical
Brian Waldon
Glance grizzly-rc1 "RC1"
Grizzly
Fix Released
Critical
Brian Waldon
Glance 2013.1 "grizzly"

Bug Description

The latest draft of JSON Patch (http://tools.ietf.org/html/draft-ietf-appsawg-json-patch-10) changed the format of the operation entity. We should update the v2 Images API implementation to target draft 10, hoping no new api changes are introduced, yet remain compatibile with draft 4.

Brian Waldon (bcwaldon)
Changed in glance:
assignee: Mark Washenberger (markwash) → Brian Waldon (bcwaldon)
Thierry Carrez (ttx)
Changed in glance:
milestone: grizzly-3 → grizzly-rc1
Brian Waldon (bcwaldon)
Changed in glance:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/22948

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/23019

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/23019
Committed: http://github.com/openstack/glance/commit/471ed9ad383c03e54f95348357b2ef6d7cf7a1f9
Submitter: Jenkins
Branch: master

commit 471ed9ad383c03e54f95348357b2ef6d7cf7a1f9
Author: Brian Waldon <email address hidden>
Date: Tue Feb 26 11:41:02 2013 -0800

    Parse JSON Schema Draft 10 in v2 Image update

    * Add new content type to PATCH /v2/images/<id> to represent support of
      JSON Schema Draft 10: application/openstack-images-v2.1-json-patch
    * Remain backwards-compatibile with existing content type
      that supports Draft 4: application/openstack-images-v2.0-json-patch
    * Fixes bug 1102476

    Change-Id: Iff4e8753a71457ad5a828553fcb0791b0f1c0445

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
Ghe Rivero (ghe.rivero)
tags: added: folsom-backport-potential
Revision history for this message
Brian Rosmaita (brian-rosmaita) wrote :

Note: The JSON Patch spec was published as RFC6902 http://tools.ietf.org/html/rfc6902
Only one substantial change from Draft 10, which is that the media type descriptor is: application/json-patch+json
This does not affect Glance's application/openstack-images-v2.1-json-patch

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.