Many functional tests don't call stop_servers after start_servers

Bug #1043416 reported by Vincent Untz on 2012-08-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Medium
Vincent Untz

Bug Description

I see many tests in the functional tests that don't call stop_servers at the end, after a call to start_servers at the beginning. test_index_with_https_auth in test_bin_glance.py is one such example, but more examples can be found in test_bin_glance.py (and maybe other files).

I don't know if this is intended or not (clearly, not having to restart the servers is a speed win). However, one net result I can see here is that I do have some processes from the test around after the tests have been run. And that is bad.

So should all tests calling start_servers() also call stop_servers()? Or should we have a way to automatically stop the servers?

Brian Waldon (bcwaldon) wrote :

We should absolutely be calling stop_servers explicitly

Fix proposed to branch: master
Review: https://review.openstack.org/12307

Changed in glance:
assignee: nobody → Vincent Untz (vuntz)
status: New → In Progress

Reviewed: https://review.openstack.org/12307
Committed: http://github.com/openstack/glance/commit/a95ec3d893b3c3ced4489a40ca4d8144ae65e310
Submitter: Jenkins
Branch: master

commit a95ec3d893b3c3ced4489a40ca4d8144ae65e310
Author: Vincent Untz <email address hidden>
Date: Mon Sep 3 08:45:57 2012 +0200

    Always call stop_servers() after having started them in tests

    Several functional tests were not stopping the servers.

    Fix bug 1043416.

    Change-Id: I362e116089e6baa3e8f9ab16be1d6c54dbf957da

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2012-09-11
Changed in glance:
milestone: none → folsom-rc1
status: Fix Committed → Fix Released
Brian Waldon (bcwaldon) on 2012-09-12
Changed in glance:
importance: Undecided → Medium
Thierry Carrez (ttx) on 2012-09-27
Changed in glance:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers