| 2019-02-20 09:13:50 |
Michal Arbet |
bug |
|
|
added bug |
| 2019-02-20 09:15:54 |
Michal Arbet |
affects |
glance |
glance-store |
|
| 2019-02-20 10:28:14 |
Michal Arbet |
glance-store: assignee |
|
Michal Arbet (michalarbet) |
|
| 2019-02-20 10:30:59 |
OpenStack Infra |
glance-store: status |
New |
In Progress |
|
| 2019-02-22 07:51:35 |
OpenStack Infra |
glance-store: status |
In Progress |
Fix Released |
|
| 2019-06-07 08:32:27 |
Edward Hope-Morley |
description |
Hello, found a bug in glance. Glance is storing bad direct_url='rbd://b%27868c2b5d-12f1-4f3f-aa2a-5701a3bb1041%27/images/7b1f429e-ad2f-40b2-be9e-8552edae8938/snap' in database. This is causing several problems, as in https://bugs.launchpad.net/cinder/+bug/1816468
root@openstack-controller:/tmp# openstack image create --container-format bare --disk-format raw --file cirros-0.3.4-x86_64-disk.img cirros-test-1
+------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Field | Value |
+------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| checksum | ee1eca47dc88f4879d8a229cc70a07c6 |
| container_format | bare |
| created_at | 2019-02-20T09:08:45Z |
| disk_format | raw |
| file | /v2/images/7b1f429e-ad2f-40b2-be9e-8552edae8938/file |
| id | 7b1f429e-ad2f-40b2-be9e-8552edae8938 |
| min_disk | 0 |
| min_ram | 0 |
| name | cirros-test-1 |
| owner | ba5ef70fd99642fdb75c9307c88b1164 |
| properties | direct_url='rbd://b%27868c2b5d-12f1-4f3f-aa2a-5701a3bb1041%27/images/7b1f429e-ad2f-40b2-be9e-8552edae8938/snap', os_hash_algo='sha512', os_hash_value='1b03ca1bc3fafe448b90583c12f367949f8b0e665685979d95b004e48574b953316799e23240f4f739d1b5eb4c4ca24d38fdc6f4f9d8247a2bc64db25d6bbdb2', os_hidden='False' |
| protected | False |
| schema | /v2/schemas/image |
| size | 13287936 |
| status | active |
| tags | |
| updated_at | 2019-02-20T09:08:48Z |
| virtual_size | None |
| visibility | shared |
+------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
mysql> select * from image_locations where image_id = '7b1f429e-ad2f-40b2-be9e-8552edae8938'\G;
*************************** 1. row ***************************
id: 32
image_id: 7b1f429e-ad2f-40b2-be9e-8552edae8938
value: rbd://b%27868c2b5d-12f1-4f3f-aa2a-5701a3bb1041%27/images/7b1f429e-ad2f-40b2-be9e-8552edae8938/snap
created_at: 2019-02-20 09:08:48
updated_at: 2019-02-20 09:08:48
deleted_at: NULL
deleted: 0
meta_data: {}
status: active
1 row in set (0.00 sec)
ERROR:
No query specified
get_fsid function from librados returns different ID representation, in py2 it is STR, in py3 it is bytes.
It can be fixed by oslo_utils.encodeutils.safe_decode
I will post the change. |
[Impact]
For >= rocky (i.e. if using py3 packages) librados.cluster.get_fsid() is returning a binary string which results in spurious/invalid invalid characters being stored in the database e.g. for the image_location. This patch ensures that the value is converted to a normal string.
[Test Case]
* deploy openstack rocky (using p3 packages)
* deploy ceph and use for glance backend
* set
/etc/glance/glance-api.conf:show_multiple_locations = True
/etc/glance/glance-api.conf:show_image_direct_url = True
* upload image
* query image_locations table in glance db
mysql -h$host -u${user} -p$passwd glance -e'select * from image_locations;'
* ensure that the stored value is correct i.e. does not have "b%27" at the beginning.
[Regression Potential]
None expected
[Other Info]
Upgrading to this patch won't fix existing images, they will need to be manually updated in the database.
----------------------------------------------------------------------------
Hello, found a bug in glance. Glance is storing bad direct_url='rbd://b%27868c2b5d-12f1-4f3f-aa2a-5701a3bb1041%27/images/7b1f429e-ad2f-40b2-be9e-8552edae8938/snap' in database. This is causing several problems, as in https://bugs.launchpad.net/cinder/+bug/1816468
root@openstack-controller:/tmp# openstack image create --container-format bare --disk-format raw --file cirros-0.3.4-x86_64-disk.img cirros-test-1
+------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Field | Value |
+------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| checksum | ee1eca47dc88f4879d8a229cc70a07c6 |
| container_format | bare |
| created_at | 2019-02-20T09:08:45Z |
| disk_format | raw |
| file | /v2/images/7b1f429e-ad2f-40b2-be9e-8552edae8938/file |
| id | 7b1f429e-ad2f-40b2-be9e-8552edae8938 |
| min_disk | 0 |
| min_ram | 0 |
| name | cirros-test-1 |
| owner | ba5ef70fd99642fdb75c9307c88b1164 |
| properties | direct_url='rbd://b%27868c2b5d-12f1-4f3f-aa2a-5701a3bb1041%27/images/7b1f429e-ad2f-40b2-be9e-8552edae8938/snap', os_hash_algo='sha512', os_hash_value='1b03ca1bc3fafe448b90583c12f367949f8b0e665685979d95b004e48574b953316799e23240f4f739d1b5eb4c4ca24d38fdc6f4f9d8247a2bc64db25d6bbdb2', os_hidden='False' |
| protected | False |
| schema | /v2/schemas/image |
| size | 13287936 |
| status | active |
| tags | |
| updated_at | 2019-02-20T09:08:48Z |
| virtual_size | None |
| visibility | shared |
+------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
mysql> select * from image_locations where image_id = '7b1f429e-ad2f-40b2-be9e-8552edae8938'\G;
*************************** 1. row ***************************
id: 32
image_id: 7b1f429e-ad2f-40b2-be9e-8552edae8938
value: rbd://b%27868c2b5d-12f1-4f3f-aa2a-5701a3bb1041%27/images/7b1f429e-ad2f-40b2-be9e-8552edae8938/snap
created_at: 2019-02-20 09:08:48
updated_at: 2019-02-20 09:08:48
deleted_at: NULL
deleted: 0
meta_data: {}
status: active
1 row in set (0.00 sec)
ERROR:
No query specified
get_fsid function from librados returns different ID representation, in py2 it is STR, in py3 it is bytes.
It can be fixed by oslo_utils.encodeutils.safe_decode
I will post the change. |
|
| 2019-06-07 08:32:34 |
Edward Hope-Morley |
summary |
Python3 librados incompatibility |
[SRU] Python3 librados incompatibility |
|
| 2019-06-07 08:32:42 |
Edward Hope-Morley |
tags |
|
sts-sru-needed |
|
| 2019-06-07 08:32:51 |
Edward Hope-Morley |
bug task added |
|
cloud-archive |
|
| 2019-06-07 08:33:02 |
Edward Hope-Morley |
nominated for series |
|
cloud-archive/rocky |
|
| 2019-06-07 08:33:02 |
Edward Hope-Morley |
bug task added |
|
cloud-archive/rocky |
|
| 2019-06-07 08:33:02 |
Edward Hope-Morley |
nominated for series |
|
cloud-archive/stein |
|
| 2019-06-07 08:33:02 |
Edward Hope-Morley |
bug task added |
|
cloud-archive/stein |
|
| 2019-06-07 08:35:05 |
Edward Hope-Morley |
cloud-archive/stein: status |
New |
Fix Released |
|
| 2019-06-07 08:41:50 |
Edward Hope-Morley |
bug task added |
|
python-glance-store (Ubuntu) |
|
| 2019-06-07 08:42:05 |
Edward Hope-Morley |
nominated for series |
|
Ubuntu Cosmic |
|
| 2019-06-07 08:42:05 |
Edward Hope-Morley |
bug task added |
|
python-glance-store (Ubuntu Cosmic) |
|
| 2019-06-07 08:42:05 |
Edward Hope-Morley |
nominated for series |
|
Ubuntu Disco |
|
| 2019-06-07 08:42:05 |
Edward Hope-Morley |
bug task added |
|
python-glance-store (Ubuntu Disco) |
|
| 2019-06-07 08:42:12 |
Edward Hope-Morley |
python-glance-store (Ubuntu Disco): status |
New |
Fix Released |
|
| 2019-06-07 16:36:23 |
Felipe Reyes |
tags |
sts-sru-needed |
sts sts-sru-needed |
|
| 2019-06-10 14:11:20 |
Corey Bryant |
python-glance-store (Ubuntu): status |
New |
Invalid |
|
| 2019-06-10 14:11:25 |
Corey Bryant |
python-glance-store (Ubuntu Cosmic): status |
New |
Triaged |
|
| 2019-06-10 14:11:27 |
Corey Bryant |
python-glance-store (Ubuntu Cosmic): importance |
Undecided |
High |
|
| 2019-06-10 14:25:59 |
Corey Bryant |
cloud-archive/rocky: status |
New |
Triaged |
|
| 2019-06-10 14:26:02 |
Corey Bryant |
cloud-archive/rocky: importance |
Undecided |
High |
|
| 2019-06-10 15:11:12 |
Corey Bryant |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2019-06-10 16:22:58 |
Ryan Beisner |
bug |
|
|
added subscriber Ryan Beisner |
| 2019-06-10 17:32:53 |
Dmitrii Shcherbakov |
bug |
|
|
added subscriber Dmitrii Shcherbakov |
| 2019-06-18 18:50:05 |
Brian Murray |
python-glance-store (Ubuntu Cosmic): status |
Triaged |
Fix Committed |
|
| 2019-06-18 18:50:10 |
Brian Murray |
bug |
|
|
added subscriber SRU Verification |
| 2019-06-18 18:50:16 |
Brian Murray |
tags |
sts sts-sru-needed |
sts sts-sru-needed verification-needed verification-needed-cosmic |
|
| 2019-06-26 13:09:25 |
Corey Bryant |
cloud-archive/rocky: status |
Triaged |
Fix Committed |
|
| 2019-06-26 13:09:26 |
Corey Bryant |
tags |
sts sts-sru-needed verification-needed verification-needed-cosmic |
sts sts-sru-needed verification-needed verification-needed-cosmic verification-rocky-needed |
|
| 2019-07-08 12:06:06 |
Edward Hope-Morley |
tags |
sts sts-sru-needed verification-needed verification-needed-cosmic verification-rocky-needed |
sts sts-sru-needed verification-done-cosmic verification-needed verification-rocky-needed |
|
| 2019-07-09 10:38:30 |
Edward Hope-Morley |
tags |
sts sts-sru-needed verification-done-cosmic verification-needed verification-rocky-needed |
sts sts-sru-needed verification-done verification-done-cosmic verification-rocky-done |
|
| 2019-07-11 08:50:38 |
Launchpad Janitor |
python-glance-store (Ubuntu Cosmic): status |
Fix Committed |
Fix Released |
|
| 2019-07-11 08:51:23 |
Łukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2019-07-11 13:08:15 |
Corey Bryant |
cloud-archive/rocky: status |
Fix Committed |
Fix Released |
|
| 2020-02-26 11:04:03 |
Erno Kuvaja |
nominated for series |
|
glance-store/stein |
|
| 2020-02-26 11:04:03 |
Erno Kuvaja |
bug task added |
|
glance-store/stein |
|
| 2020-02-26 11:04:03 |
Erno Kuvaja |
nominated for series |
|
glance-store/rocky |
|
| 2020-02-26 11:04:03 |
Erno Kuvaja |
bug task added |
|
glance-store/rocky |
|
| 2020-02-26 11:04:03 |
Erno Kuvaja |
nominated for series |
|
glance-store/train |
|
| 2020-02-26 11:04:03 |
Erno Kuvaja |
bug task added |
|
glance-store/train |
|
| 2020-03-05 15:52:09 |
OpenStack Infra |
glance-store/rocky: status |
New |
Fix Committed |
|
