stable mitaka gate broken after swiftclient release

Bug #1556059 reported by Erno Kuvaja
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
glance_store
Fix Released
Critical
Unassigned
Mitaka
Fix Committed
Critical
Unassigned

Bug Description

Due to how glance_store unit tests are implemented (stubbing private functions from swiftclient) latest swiftclient release broke the gate.

Revision history for this message
Erno Kuvaja (jokke) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance_store (master)

Reviewed: https://review.openstack.org/291495
Committed: https://git.openstack.org/cgit/openstack/glance_store/commit/?id=851508c2bff70d2857f7d0cdb9eb684f0288450b
Submitter: Jenkins
Branch: master

commit 851508c2bff70d2857f7d0cdb9eb684f0288450b
Author: Tom Cocozzello <email address hidden>
Date: Thu Mar 10 11:51:45 2016 -0600

    Mock swiftclient's functions in tests

    swiftclient changed their code so if the chuck size is greater than
    zero it will return a generator otherwise it will return the response.
    Which would be the object you are looking for. This causes our tests
    to fail since they are always expecting the response instead of a
    generator.

    Closes-bug: 1556059

    Co-Authored-by: avarner <email address hidden>
    Change-Id: I62cc037493af87373a75e37e2d9f33b8aedf9889

Changed in glance-store:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance_store (stable/mitaka)

Reviewed: https://review.openstack.org/291682
Committed: https://git.openstack.org/cgit/openstack/glance_store/commit/?id=4600adb85aebb0402728fd7b053b0e61d0d586c2
Submitter: Jenkins
Branch: stable/mitaka

commit 4600adb85aebb0402728fd7b053b0e61d0d586c2
Author: Tom Cocozzello <email address hidden>
Date: Thu Mar 10 11:51:45 2016 -0600

    Mock swiftclient's functions in tests

    swiftclient changed their code so if the chuck size is greater than
    zero it will return a generator otherwise it will return the response.
    Which would be the object you are looking for. This causes our tests
    to fail since they are always expecting the response instead of a
    generator.

    Closes-bug: 1556059

    (cherry picked from commit 851508c2bff70d2857f7d0cdb9eb684f0288450b)
    Co-Authored-by: avarner <email address hidden>
    Change-Id: I62cc037493af87373a75e37e2d9f33b8aedf9889

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to glance_store (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/301373

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to glance_store (master)

Reviewed: https://review.openstack.org/301373
Committed: https://git.openstack.org/cgit/openstack/glance_store/commit/?id=9addf29b5208289ab90e6505e33ff7e87c6fae82
Submitter: Jenkins
Branch: master

commit 9addf29b5208289ab90e6505e33ff7e87c6fae82
Author: Tim Burke <email address hidden>
Date: Mon Apr 4 15:06:01 2016 -0700

    Fix swiftclient mocks

    In particular, stop mocking out some internal details like
    swiftclient.client.Connection._retry

    Change-Id: If118b9656ae1e87139c0d48dcc97c1daee948a85
    Related-Change: I62cc037493af87373a75e37e2d9f33b8aedf9889
    Related-Bug: 1556059

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/glance_store 0.14.0

This issue was fixed in the openstack/glance_store 0.14.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/glance_store 0.13.1

This issue was fixed in the openstack/glance_store 0.13.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.