cinder: missing libraries are not detected until certain API operations fail

Bug #2043583 reported by Takashi Kajinami
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
glance_store
Fix Released
Undecided
Takashi Kajinami

Bug Description

The cinder store driver requires os-brick and oslo-privsep in addition to cinderclient.

While cinderclient is checked when a cinder store is initialized, the other libraries are not checked during the initialization.

As a result, a cinder store can be initialized without any error even when os-brick or oslo-privsep is missing. The missing libraries causes failure when the cinder store driver tries to access data in a cinder volume, so create image or delete image may fail with server error caused by internal AttributeError.

We should check the required libraries when a cinder store is being initialized so that operators can detect their incomplete deployment, rather than exposing server error to users.

Changed in glance-store:
assignee: nobody → Takashi Kajinami (kajinamit)
description: updated
description: updated
description: updated
Changed in glance-store:
status: New → In Progress
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance_store (master)

Reviewed: https://review.opendev.org/c/openstack/glance_store/+/900121
Committed: https://opendev.org/openstack/glance_store/commit/651f41a95a1703c5717fc47b8d9847d4da98c7de
Submitter: "Zuul (22348)"
Branch: master

commit 651f41a95a1703c5717fc47b8d9847d4da98c7de
Author: Takashi Kajinami <email address hidden>
Date: Sun Nov 5 14:25:42 2023 +0900

    cinder: Catch missing dependencies

    Cinder store requires a few additional dependencies.
     - cinderclient
     - os.brick
     - oslo.provsep

    Currently the driver handles missing cinderclient, but it does not
    properly treat in case one of the other two libraries is unavailable.

    Note that oslo.rootwrap is also part of the additional dependencies but
    this library is not directly imported. So we do not implement check
    at store initialization.

    Closes-Bug: #2043583
    Change-Id: I4ea0a9749fdd821f3f958f77a2923b0fafefa471

Changed in glance-store:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/glance_store 4.7.0

This issue was fixed in the openstack/glance_store 4.7.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.