[Rbd] rados_connect_timeout has no effect

[Cyril Roelandt]

We currently pass a 'timeout' argument to rados.Rados.connect (see https://opendev.org/openstack/glance_store/commit/6851cab51a3d5dbf018f755efee8e0e640ac12ab). Unfortunately, its value is silently ignored (see https://docs.ceph.com/en/latest/rados/api/python/#rados.Rados.connect).

Users setting a value for rados_connect_timeout (which is what we currently pass to rados.Rados.connect) are therefore not doing anything.

We should deprecate the option and encourage users to use client_mount_timeout in Ceph's config (but we might want a Ceph expert to confirm that :p).

[Cyril Roelandt (cyril-roelandt)]

https://review.opendev.org/c/openstack/glance_store/+/852044

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/glance_store/+/852044
Committed: https://opendev.org/openstack/glance_store/commit/b1d0feeba4e16046c7840bd4966f31a0e7527e67
Submitter: "Zuul (22348)"
Branch: master

commit b1d0feeba4e16046c7840bd4966f31a0e7527e67
Author: Cyril Roelandt <email address hidden>
Date: Wed Aug 3 18:57:05 2022 +0200

    Rbd: Deprecate unused rados_connect_timeout

    This option determines the value we pass as the "timeout" argument to
    rados.Rados.connect. Unfortunately, this argument is silently ignored by
    librados[1].

    [1] https://docs.ceph.com/en/latest/rados/api/python/#rados.Rados.connect

    Closes-Bug: #1983499
    Change-Id: I819df987f690c7a8c0a1153ad0e30bd5dbeb7b57

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/glance_store 4.3.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/glance_store/+/894514
Committed: https://opendev.org/openstack/glance_store/commit/c197bbdccadf799be2d86da28f1d2302ccf5e1e8
Submitter: "Zuul (22348)"
Branch: master

commit c197bbdccadf799be2d86da28f1d2302ccf5e1e8
Author: Takashi Kajinami <email address hidden>
Date: Mon Nov 27 11:33:12 2023 +0900

    RBD: Use rados_connect_timeout to override timeout

    This imports the existing rados_connect_timeout option handling in
    cinder so that users can use a different timeouts for Glance
    specifically, instead of relying on the global ceph.conf options.

    This parameter was initially deprecated in Zed release by [1] and has
    had no effect since then, but this change restores the parameter with
    the logic to override the timeout value in RADOS client.

    [1] b1d0feeba4e16046c7840bd4966f31a0e7527e67

    Related-Bug: #1983499
    Change-Id: Ib370f527c06dc85bcfd9df6ca1efb2a4e8cb5e7d