Possible race conditions with cinder (nfs) store

[Rajat Dhasmana]

With cinder configured as glance store and nfs as cinder backend, there might be a possible race when creating multiple images concurrently during mounting.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/716874
Committed: https://git.openstack.org/cgit/openstack/glance_store/commit/?id=f5d46996139593f6249138bcc9f09b6120f0034a
Submitter: Zuul
Branch: master

commit f5d46996139593f6249138bcc9f09b6120f0034a
Author: whoami-rajat <email address hidden>
Date: Wed Apr 1 14:18:44 2020 +0000

    Add lock per share for cinder nfs mount/umount

    With cinder configured as glance store and nfs as cinder backend,
    if we create multiple images concurrently into the same share,
    there might be race conditions.
    This patch ensures a lock per export to avoid the race conditions.

    This patch also introduces a reference counting mechamism for unmounting
    which will unmount the share if no active thread/process is using it.

    Closes-Bug: #1870289

    Change-Id: I9197f64e29a0ae2e0a58186f1a70aa134f7f1db6

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/726914

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/726914
Committed: https://git.openstack.org/cgit/openstack/glance_store/commit/?id=b37e7f2f3c3faf3b6e4d11eeb3e866211e13b85e
Submitter: Zuul
Branch: stable/ussuri

commit b37e7f2f3c3faf3b6e4d11eeb3e866211e13b85e
Author: whoami-rajat <email address hidden>
Date: Wed Apr 1 14:18:44 2020 +0000

    Add lock per share for cinder nfs mount/umount

    With cinder configured as glance store and nfs as cinder backend,
    if we create multiple images concurrently into the same share,
    there might be race conditions.
    This patch ensures a lock per export to avoid the race conditions.

    This patch also introduces a reference counting mechamism for unmounting
    which will unmount the share if no active thread/process is using it.

    Closes-Bug: #1870289

    Change-Id: I9197f64e29a0ae2e0a58186f1a70aa134f7f1db6
    (cherry picked from commit f5d46996139593f6249138bcc9f09b6120f0034a)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/726650
Committed: https://git.openstack.org/cgit/openstack/glance_store/commit/?id=bc62bb4ab3874cd5938371faa8a0cb660a1eb2fd
Submitter: Zuul
Branch: stable/train

commit bc62bb4ab3874cd5938371faa8a0cb660a1eb2fd
Author: whoami-rajat <email address hidden>
Date: Wed Apr 1 14:18:44 2020 +0000

    Add lock per share for cinder nfs mount/umount

    With cinder configured as glance store and nfs as cinder backend,
    if we create multiple images concurrently into the same share,
    there might be race conditions.
    This patch ensures a lock per export to avoid the race conditions.

    This patch also introduces a reference counting mechamism for unmounting
    which will unmount the share if no active thread/process is using it.

    Closes-Bug: #1870289

    Change-Id: I9197f64e29a0ae2e0a58186f1a70aa134f7f1db6
    (cherry picked from commit f5d46996139593f6249138bcc9f09b6120f0034a)
    (cherry picked from commit b37e7f2f3c3faf3b6e4d11eeb3e866211e13b85e)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/glance_store 2.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/glance_store train-eol release.