CooperativeReader not py3-ready

Bug #1818915 reported by Brian Rosmaita on 2019-03-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
glance_store
Status tracked in Stein
Rocky
Undecided
Unassigned
Stein
High
Unassigned

Bug Description

Tim Burke noticed this in IRC today:
https://github.com/openstack/glance_store/blob/0.28.0/glance_store/common/utils.py#L138

In the CooperativeReader class:
    def read(self, length=None):
        """Return the next chunk of the underlying iterator.

        This is replaced with cooperative_read in __init__ if the underlying
        fd already supports read().
        """
        if self.iterator is None:
            self.iterator = self.__iter__()
        try:
            return next(self.iterator)
        except StopIteration:
            return ''

This needs to return b''.

Changed in glance-store:
status: New → Triaged
importance: Undecided → High
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers