CooperativeReader not py3-ready
Bug #1818915 reported by
Brian Rosmaita
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
glance_store |
Fix Released
|
High
|
Unassigned | ||
Rocky |
New
|
Undecided
|
Unassigned | ||
Stein |
Fix Released
|
High
|
Unassigned |
Bug Description
Tim Burke noticed this in IRC today:
https:/
In the CooperativeReader class:
def read(self, length=None):
"""Return the next chunk of the underlying iterator.
This is replaced with cooperative_read in __init__ if the underlying
fd already supports read().
"""
if self.iterator is None:
try:
return next(self.iterator)
except StopIteration:
return ''
This needs to return b''.
Changed in glance-store: | |
status: | New → Triaged |
importance: | Undecided → High |
To post a comment you must log in.
Reviewed: https:/ /review. opendev. org/651941 /git.openstack. org/cgit/ openstack/ glance_ store/commit/ ?id=0a3166558f1 b2f382075145502 576919cecec61e
Committed: https:/
Submitter: Zuul
Branch: master
commit 0a3166558f1b2f3 820751455025769 19cecec61e
Author: Cyril Roelandt <email address hidden>
Date: Fri Apr 12 01:40:04 2019 +0200
Python3: Fix return type on CooperativeRead er.read
Cooperative Reader. read() should return bytes. A similar change was
merged in Glance.
Change-Id: Iee3b49235be2af 64eac3933e41c7e 44fc1a564f4
Closes-Bug: #1818915