glance_store

interface function for multihash not wrapped correctly

Bug #1784420 reported by Brian Rosmaita on 2018-07-30

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
glance_store	Fix Released	Critical	Brian Rosmaita	glance_store 0.26.1 "rocky-bugfix-1"
Rocky	Fix Released	Critical	Brian Rosmaita	glance_store 0.26.1 "rocky-bugfix-1"
Stein	Fix Released	Critical	Brian Rosmaita	glance_store 0.27.0 "stein-1"

Bug Description

The most recent glance_store release contains support for computing secure hash values of stored data, but the function called by Glance to store data was not wrapped correctly. As a result, the computed secure hash value is not available to Glance.

Need to wrap store_add_to_backend_with_multihash() so that Glance can use it.

Tags:

OpenStack Infra (hudson-openstack) on 2018-07-30

Changed in glance-store:
status:	Triaged → In Progress

Revision history for this message

Brian Rosmaita (brian-rosmaita) wrote on 2018-07-30:

https://review.openstack.org/#/c/587098/

summary:

- missing multihash version of interface function
+ interface function for multihash not wrapped correctly

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-07-31: Fix proposed to glance_store (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/587516

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-07-31: Fix merged to glance_store (master)

Reviewed: https://review.openstack.org/587098
Committed: https://git.openstack.org/cgit/openstack/glance_store/commit/?id=4d4cf1559cf393a2a10a458f83209cbeb2756e49
Submitter: Zuul
Branch: master

commit 4d4cf1559cf393a2a10a458f83209cbeb2756e49
Author: Brian Rosmaita <email address hidden>
Date: Mon Jul 30 11:54:27 2018 -0400

Wrap interface function for multihash correctly

    The store_add_to_backend_with_multihash() function was not wrapped
    correctly so that Glance could consume the secure hash value. This
    patch adds the correct wrapping.

Closes-bug: #1784420

Change-Id: I7a94dfffb61fc212abb58c1e1aec5884474b6aa8

Changed in glance-store:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-07-31: Fix merged to glance_store (stable/rocky)

Reviewed: https://review.openstack.org/587516
Committed: https://git.openstack.org/cgit/openstack/glance_store/commit/?id=cfd0567b4f22760aa5526bdc0f955213084b5222
Submitter: Zuul
Branch: stable/rocky

commit cfd0567b4f22760aa5526bdc0f955213084b5222
Author: Brian Rosmaita <email address hidden>
Date: Mon Jul 30 11:54:27 2018 -0400

Wrap interface function for multihash correctly

    The store_add_to_backend_with_multihash() function was not wrapped
    correctly so that Glance could consume the secure hash value. This
    patch adds the correct wrapping.

Closes-bug: #1784420

(cherry picked from commit 4d4cf1559cf393a2a10a458f83209cbeb2756e49)

Change-Id: I7a94dfffb61fc212abb58c1e1aec5884474b6aa8

tags:

added: in-stable-rocky

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-07-31: Fix included in openstack/glance_store 0.26.1

This issue was fixed in the openstack/glance_store 0.26.1 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-11-01: Fix included in openstack/glance_store 0.27.0

This issue was fixed in the openstack/glance_store 0.27.0 release.