_get_this_repo fails if user is not in top level of git repo
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad tooling for Git |
Fix Released
|
High
|
Robert C Jennings |
Bug Description
When git lp-propose is run from a sub directory below the root of the repo we get a traceback. As a user I can ask git to find the root of the tree using 'git rev-parse --show-toplevel'. And for your initialization of git.Repo(... you can pass 'search_
$ git clone https:/
$ cd gitlptools/
$ git lp-propose ....
Traceback (most recent call last):
File "/snap/
load_
File "/snap/
options = parse_args_
File "/snap/
options = parser.
File "/snap/
args, argv = self.parse_
File "/snap/
namespace, args = self._parse_
File "/snap/
stop_index = consume_
File "/snap/
take_
File "/snap/
action(self, namespace, argument_values, option_string)
File "/snap/
merge_target = get_merge_
File "/snap/
return git.Repo(repo_path)
File "/snap/
raise InvalidGitRepos
git.exc.
Related branches
- Adam Collard (community): Approve
-
Diff: 13 lines (+1/-1)1 file modifiedsrc/gitlptools/__init__.py (+1/-1)
Changed in gitlptools: | |
status: | New → In Progress |
importance: | Undecided → High |
assignee: | nobody → Robert C Jennings (rcj) |
Changed in gitlptools: | |
status: | In Progress → Fix Committed |
status: | Fix Committed → Won't Fix |
status: | Won't Fix → Fix Released |