export-orig shows trace when no tarball available
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
git-ubuntu |
New
|
Undecided
|
Unassigned |
Bug Description
When reviewing a merge proposal, this can crop up:
php-transition-
03/23/2020 22:22:50 - WARNING:No pristine-tar data found for 1.2.10+ds1
03/23/2020 22:22:55 - INFO:New upstream version detected (1.2.10+ds1) which is after the last published upstream version (1.2.1+ds1).
Traceback (most recent call last):
File "/snap/
load_
File "/snap/
sys.
File "/snap/
if len(tarballs) > 0:
TypeError: object of type 'NoneType' has no len()
Fix is probably something like:
tarballs = main(repo, args.commit, orig_search_list)
if tarballs and len(tarballs) > 0:
return 0
else:
return 1
The problem is that since it's a merge, the necessary tarball is (obviously) not yet in the Ubuntu archive. In this case it's necessary to use the --for-merge argument:
git ubuntu export-orig --for-merge
07/27/2020 09:48:33 - WARNING:No pristine-tar data found for 8.32
07/27/2020 09:48:40 - INFO:Downloading coreutils_
07/27/2020 09:48:43 - INFO:Downloading coreutils_
07/27/2020 09:48:45 - INFO:Downloading coreutils_
07/27/2020 09:48:45 - INFO:Successfully fetched:
/home/bryce/
using fetch_orig_
Related branches
- Server Team CI bot: Approve (continuous-integration)
- Robie Basak: Needs Fixing
-
Diff: 32 lines (+8/-0)1 file modifiedgitubuntu/build.py (+8/-0)
- Server Team CI bot: Approve (continuous-integration)
- Bryce Harrington: Approve
-
Diff: 21 lines (+2/-1)1 file modifiedgitubuntu/build.py (+2/-1)
tags: | added: export-orig |
Alternatively, build.fetch_orig() could be modified to always return an empty list on error.