git-ubuntu depends on /usr/bin/lxc from the host system instead of it being included in the snap

[Robie Basak]

This is a note to self on a suspicion. I need to confirm if it is true.

[Robie Basak (racb)]

ubuntu@rbasak-gu-test:~$ snap run --shell git-ubuntu.self-test
ubuntu@rbasak-gu-test:~$ lxc
Command 'lxc' is available in '/usr/bin/lxc'
The command could not be located because '/usr/bin' is not included in the PATH environment variable.
lxc: command not found

[Nish Aravamudan (nacc)]

Yes, this is the design. Configuring lxd is outside the scope of
git-ubuntu. We could add a dependency on an interface provided by the lxd
snap. But it makes no sense to package lxd ourselves.

On Tue, Dec 4, 2018, 16:50 Robie Basak <<email address hidden> wrote:

> ubuntu@rbasak-gu-test:~$ snap run --shell git-ubuntu.self-test
> ubuntu@rbasak-gu-test:~$ lxc
> Command 'lxc' is available in '/usr/bin/lxc'
> The command could not be located because '/usr/bin' is not included in the
> PATH environment variable.
> lxc: command not found
>
>
> ** Tags added: snap
>
> --
> You received this bug notification because you are a member of Ubuntu
> Server Dev import team, which is subscribed to usd-importer.
> https://bugs.launchpad.net/bugs/1806778
>
> Title:
> git-ubuntu depends on /usr/bin/lxc from the host system instead of it
> being included in the snap
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/usd-importer/+bug/1806778/+subscriptions
>
> Launchpad-Notification-Type: bug
> Launchpad-Bug: product=usd-importer; status=New; importance=Undecided;
> assignee=None;
> Launchpad-Bug-Tags: snap
> Launchpad-Bug-Information-Type: Public
> Launchpad-Bug-Private: no
> Launchpad-Bug-Security-Vulnerability: no
> Launchpad-Bug-Commenters: racb
> Launchpad-Bug-Reporter: Robie Basak (racb)
> Launchpad-Bug-Modifier: Robie Basak (racb)
> Launchpad-Message-Rationale: Subscriber (usd-importer) @usd-import-team
> Launchpad-Message-For: usd-import-team
>

[Robie Basak (racb)]

Thanks. What bothers me is that the classic snap (in my understanding)
should run anywhere snaps can run, with the "classicness" being for the
purposes of git-ubuntu being able to get to the user's git repository it
is to act upon only. AIUI, any reliance on any other thing on the host
system is a bug in the snap.

Using an interface provided by the lxd snap seems like the way to go.

Fairly low priority though.

[Nish Aravamudan (nacc)]

On Tue, Dec 4, 2018, 18:10 Robie Basak <<email address hidden> wrote:

> Thanks. What bothers me is that the classic snap (in my understanding)
> should run anywhere snaps can run,

My understanding of classic snaps is they basically have no
rules/restrictions :). I made the rule of ship everything we need, since
there was no dependency resolution to snaps.

with the "classicness" being for the
> purposes of git-ubuntu being able to get to the user's git repository it
> is to act upon only.

That is true in principle. If we had a general filesystem interface we
could be confined.

AIUI, any reliance on any other thing on the host
> system is a bug in the snap.
>
> Using an interface provided by the lxd snap seems like the way to go.
>

Yeah, if it exists. If it doesn't you will need to request one from lxd and
it will have to be added to the store first, I think.

Fairly low priority though.
>

Yeah, this affects build only, and I think it's a reasonable requirement
for the time being.