scriptutils.py::_iter_source_paragraphs selects the decompression algorithm non-deterministically
Bug #1801720 reported by
Robie Basak
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
git-ubuntu |
Triaged
|
Low
|
Unassigned |
Bug Description
I just noticed this:
compressions = {
'.xz': lzma.decompress,
'.bz2': bz2.decompress,
'.gz': gzip.decompress,
}
[...]
for compression, decompresser in compressions.
We should probably use an OrderedDict and decide what order to try decompressing in. This shouldn't cause a functional problem currently in theory, but it would be helpful to be deterministic in case of an unrelated bug or problem.
To post a comment you must log in.
Ack, I don't think a given tarball can be decompressed by more than one of
these, but for determinism I'm fine with ordering it.
On Mon, Nov 5, 2018, 5:55 AM Robie Basak <<email address hidden> wrote:
> Public bug reported: items() : /bugs.launchpad .net/bugs/ 1801720 py::_iter_ source_ paragraphs selects the decompression ically /bugs.launchpad .net/usd- importer/ +bug/1801720/ +subscriptions Notification- Type: bug usd-importer; status=Triaged; importance=Low; Bug-Information -Type: Public Bug-Private: no Bug-Security- Vulnerability: no Bug-Commenters: racb Bug-Reporter: Robie Basak (racb) Bug-Modifier: Robie Basak (racb) Message- Rationale: Subscriber (usd-importer) @usd-import-team Message- For: usd-import-team
>
> I just noticed this:
>
> compressions = {
> '.xz': lzma.decompress,
> '.bz2': bz2.decompress,
> '.gz': gzip.decompress,
> }
> [...]
> for compression, decompresser in compressions.
>
> We should probably use an OrderedDict and decide what order to try
> decompressing in. This shouldn't cause a functional problem currently in
> theory, but it would be helpful to be deterministic in case of an
> unrelated bug or problem.
>
> ** Affects: usd-importer
> Importance: Low
> Status: Triaged
>
> --
> You received this bug notification because you are a member of Ubuntu
> Server Dev import team, which is subscribed to usd-importer.
> https:/
>
> Title:
> scriptutils.
> algorithm non-determinist
>
> To manage notifications about this bug go to:
> https:/
>
> Launchpad-
> Launchpad-Bug: product=
> assignee=None;
> Launchpad-
> Launchpad-
> Launchpad-
> Launchpad-
> Launchpad-
> Launchpad-
> Launchpad-
> Launchpad-
>