log output ignores verbose option in submodules
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
git-ubuntu |
New
|
Undecided
|
Unassigned |
Bug Description
While debugging a MP I reviewed I found that -v is somewhat ignored in submodules.
I assume this is to some extend since 0c515af9
Although without the history on that I'm not sure which way you want to solve it.
But as an example any logging of level info/debug in gitubuntu/build.py does not get out.
Found while running:
git ubuntu lint -v paelzer/
Which should have like:
01/10/2018 15:42:50 - DEBUG:Successfully fetched :
../strongswan_
using fetch_orig_
But it was not appearing.
I found that the current init of loglevel in main is not correctly passed.
So all submodules use the default of >=warn and that way out verbose logs are much less useful.
On 10.01.2018 [14:55:30 -0000], ChristianEhrhardt wrote: lp1734207- fix-mulsipsk- zesty
> Public bug reported:
>
> While debugging a MP I reviewed I found that -v is somewhat ignored in
> submodules. I assume this is to some extend since 0c515af9
>
> Although without the history on that I'm not sure which way you want to
> solve it.
>
> But as an example any logging of level info/debug in
> gitubuntu/build.py does not get out.
> Found while running:
> git ubuntu lint -v paelzer/
Do you have more examples than lint -> build?
> Which should have like: 5.5.1.orig. tar.bz2 from_parent_ dir(source= None)
> 01/10/2018 15:42:50 - DEBUG:Successfully fetched :
> ../strongswan_
> using fetch_orig_
>
> But it was not appearing.
> I found that the current init of loglevel in main is not correctly passed.
> So all submodules use the default of >=warn and that way out verbose
> logs are much less useful.
This is intentional in this case, because the above output would be
surprising in general. You are right, though, if verbose is set in the
caller we should send it to the callee. We don't currently have any
mechanism for this, I don't think, but I'll look (at the lowest level
like this in lint, we no longer necessarily know if we are verbose or
not).