git-ubuntu

lint fails if not in top level directory

Bug #1738956 reported by Robie Basak
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
git-ubuntu
Confirmed
Wishlist
Nish Aravamudan
git-ubuntu future

Bug Description

Using: 0.6.2+git49.967f050 (345)

Actual:

robie@xps:/tmp/review/strongswan/debian$ git ubuntu lint
12/19/2017 07:33:47 - ERROR:Specified directory /tmp/review/strongswan/debian must either be empty or have been previously imported to.
robie@xps:/tmp/review/strongswan/debian$ cd ..
robie@xps:/tmp/review/strongswan$ git ubuntu lint
12/19/2017 07:34:15 - WARNING:Detached HEAD, assuming no namespace for tags. Pass --lint-namespace if this is incorrect.
All lint checks passed

Expected: lint runs regardless of my pwd.

This bug also occurs when I provide a commitish on the command line. In that case even more do I consider my pwd irrelevant.

Tags: lint
Revision history for this message
Nish Aravamudan (nacc) wrote :

I believe none of our code currently handles being in a subdir of a git repo.

Changed in usd-importer:
status: New → Confirmed
importance: Undecided → Wishlist
assignee: nobody → Nish Aravamudan (nacc)
milestone: none → future
Revision history for this message
Nish Aravamudan (nacc) wrote :

We can leverage `git rev-parse --show-toplevel` if our current code is unable to find a repo at the dir.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.