imported tarball mismatches archive

[Christian Ehrhardt ]

Hi,
I just happened to find that when source-build on slof to the point where it gets the orig tarball out of the pristine-tar branches it doesn't match.

I got this out of pristine tar by doing the build:
-rw-rw-r-- 1 paelzer paelzer 417240 Aug 29 09:19 slof_20170724+dfsg.orig.tar.xz

On an upload this got rejected
File slof_20170724+dfsg.orig.tar.xz already exists in Primary Archive for Ubuntu, but uploaded version has different contents. See more information about this error in https://help.launchpad.net/Packaging/UploadErrors.
Files specified in DSC are broken or missing, skipping package unpack verification.

I did a pull-lp-source and got:
-rw-rw-r-- 1 paelzer paelzer 403024 Dez 13 15:04 slof_20170724+dfsg.orig.tar.xz

No md5sum needed, the size is different.

Workaround for now:
1. pull-lp-source
2. build with --no-pristine-tar

[Robie Basak (racb)]

14:35 <rbasak> cpaelzer: thank you for the report. I'm not sure about hash-abi-break because a change to pristine-tar won't change the main imported commit graph, but a change to upstream/ might. So I'll tag it for now.

[Nish Aravamudan (nacc)]

I'll try and dig into this next week.

[Nish Aravamudan (nacc)]

I just did the following:

nacc@pitfall:/tmp/foo$ pull-lp-source -d slof
pull-lp-source: Downloading slof version 20170724+dfsg-1ubuntu1
pull-lp-source: Downloading slof_20170724+dfsg.orig.tar.xz from archive.ubuntu.com (0.384 MiB)
pull-lp-source: Downloading slof_20170724+dfsg-1ubuntu1.debian.tar.xz from archive.ubuntu.com (0.005 MiB)
nacc@pitfall:/tmp/foo$ md5sum slof_20170724+dfsg.orig.tar.xz
d046f06beac8c9ecb312728a3ee482f0 slof_20170724+dfsg.orig.tar.xz

nacc@pitfall:/tmp$ git ubuntu clone slof
nacc@pitfall:/tmp$ cd slof/
nacc@pitfall:/tmp/slof (ubuntu/devel)$ git ubuntu export-orig
01/08/2018 11:18:38 - WARNING:pristine-tar data found for both debian and ubuntu, using ubuntu
01/08/2018 11:18:40 - INFO:Successfully fetched:
../slof_20170724+dfsg.orig.tar.xz
using fetch_orig_from_pristine_tar(source=ubuntu)
nacc@pitfall:/tmp/slof (ubuntu/devel)$ md5sum ../slof_20170724+dfsg.orig.tar.xz d046f06beac8c9ecb312728a3ee482f0 ../slof_20170724+dfsg.orig.tar.xz

So I'm unable to reproduce with the first example that refers to the same tarball.

Can you let me know what branch you were on when you did your build?

[Robie Basak (racb)]

> I'm not sure about hash-abi-break because a change to pristine-tar won't change the main imported commit graph, but a change to upstream/ might. So I'll tag it for now.

I'm not considering the upstream branches part of hash stability, so untagging.