check package version number against upload target

[Michael Hudson-Doyle]

nacc suggested I file this here :)

I'd like to have dput/whatever I use to cause new versions of a package to be built check the package version number against the upload target. Some checks come to mind:

1) Uploads to ppas must have "~ppa" in the version number
2) Uploads to the archive must not have "~ppa" in the version number
3) Uploads to non-devel series must have an appropriate version number (e.g. "~16.04.[0-9]+$" is OK for Xenial, not for yakkety or devel series, or match ".*ubuntu[0-9]+\.[0-9]+$")

[Nish Aravamudan (nacc)]

4) Check branch name matches changelog target.

[Michael Hudson-Doyle (mwhudson)]

After making a series of embarrassing mistakes trying to upload versions of docker for SRU I hacked this up: https://gist.github.com/mwhudson/616499edb1191bd99c987bbbd8781ce9

[Robie Basak (racb)]

I wonder if we could have a "git ubuntu dput [treeish]" wrapper? It could lint, then build the source, then sign and upload. If the lint fails (even if just warnings), then it would fail by default and require a --force to succeed. Then the functionality in lint should be sufficient for this use case.

It might be appropriate to require by default that the working tree is clean, as generally we only want to upload things that are fully committed. And for PPAs, we could have a --ppa option that bumps debian/changelog with a ~ppaX automatically.

Perhaps not realistic for 1.0 though.

[Bryce Harrington (bryce)]

This would be a slick feature to add to dput itself, it already has a --lintian and --check-version, but those options don't look like they'd do this.

[Michael Hudson-Doyle (mwhudson)]

FWIW, I ended up writing a wrapper for dput
https://github.com/mwhudson/dput-wrap that I still use daily. As the README
says, it might make sense to add this to dput-ng.

Cheers,
mwh

On Sat, 5 Oct 2019 at 08:41, Bryce Harrington <email address hidden>
wrote:

> This would be a slick feature to add to dput itself, it already has a
> --lintian and --check-version, but those options don't look like they'd
> do this.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1690967
>
> Title:
> check package version number against upload target
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/usd-importer/+bug/1690967/+subscriptions
>