Doesn't parse ssh-aliased urls

[Jason]

My fetch url is set to gerrit:cabs.git

My repositories .git/config has the remote:
[remote "gerrit"]
 fetch = +refs/heads/*:refs/remotes/gerrit/*
 url = gerrit:cabs.git

Which uses my ~/.ssh/config entry:
Host gerrit
User jaxelson
Hostname rams-build-vm
Port 29418
IdentityFile ~/.ssh/id_common

It seems to be a bug/misuse of python's urlparse method which is given the input "gerrit:cabs.git". The parse result is:
ParseResult(scheme='gerrit', netloc='', path='cabs.git', params='', query='', fragment='')

Which has gerrit as the scheme instead of the netloc. To remedy this you probably need to trust that the netloc can set the ssh settings necessary (such as the username and port).

An obvious workaround which I am just about to try is to use the .gitreview file instead which I will try in a few minutes and fully expect to resolve my problems

[Monty Taylor (mordred)]

Oh bother. Thanks. Using the .gitreview file will totally work - BUT, I would like to appropriately handle this case, since it's totally valid for someone to already have a gerrit remote set up.

[Marcin Cieślak (saperski)]

I have submitted a Patch Set 4 to https://review.openstack.org/#change,5720, it should improve the situation.

[David Ostrovsky (d-ostrovsky)]

>... Using the .gitreview file will totally work
Unfortunately not.
Currently I'm getting connection error, because git-review is trying to connect to the port 22 instead of 29418.
Changing on the line 259 the value 22 through deafult gerrit port makes it work:

old:

# Is origin an ssh location? Let's pull more info
if parsed_url.scheme == "ssh" and port is None:
    port = 22

new:

# Is origin an ssh location? Let's pull more info
if parsed_url.scheme == "ssh" and port is None:
    port = 29418

Even when in my .gitreview the port line is presents:

[gerrit]
host=logerrit
port=29418
project=core
defaultremote=logerrit
defaultbranch=master

[Jeremy Stanley (fungi)]

https://review.openstack.org/5720 was abandoned a year ago... is this bug still valid in 1.21/master? It seems that parse_git_show() has undergone some heavy refactoring in that time.

[@Spazm (granny-launchpad)]

I've pushed a change [ https://review.openstack.org/#/c/43248 ] that helps in the related case of port=None. As of patch set 3 it also fixes the naked ssh url case.

[Launchpad Janitor (janitor)]

[Expired for git-review because there has been no activity for 60 days.]

[Marcin Cieślak (saperski)]

Still valid as of current version

[Éric Araujo (merwok)]

I saw the same error message just now, even though the .git/config file contains a full URI.
Following advice from a mediawiki bug report, I ran the initial git review command with the C locale, and the hook installed fine.

[Cedric Brandily (cbrandily)]

Fix done in https://review.openstack.org/72751