automagically determine default branch without needing per-branch defaults in .gitreview
Bug #883176 reported by
Anne Gentle
This bug affects 4 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MediaWiki |
Invalid
|
Medium
|
|||
git-review |
Confirmed
|
Low
|
Unassigned |
Bug Description
Here's what I did:
git checkout master
git pull origin master
git checkout -b BRANCHNAME
...
git commit -a -m 'message'
git review
git log
...copy/paste the sha1 of the revision...
git checkout gerrit/
git checkout -b ANOTHERBRANCHNAME
git cherry-pick sha1pastevalue
... fix a merge conflict if needed,
grep -r "<<<<<<< HEAD" .
...
git add .
git commit -c sha1nnnnnnnnnnnnn
git review
Here's what I got:
Errors running GIT_EDITOR=true git rebase -i remotes/
Finished one cherry-pick.
# Not currently on any branch.
nothing to commit (working directory clean)
Could not apply 3688cad... Fixes bug 882781 multi_host flag addition
Changed in git-review: | |
status: | New → Confirmed |
Changed in mediawiki: | |
importance: | Unknown → Medium |
status: | Unknown → Invalid |
Changed in git-review: | |
importance: | Undecided → Low |
summary: |
- Active branch gets changed after performing a git review on a cherry- - pick + automagically determine default branch without needing per-branch + defaults in .gitreview |
To post a comment you must log in.
When a merge conflict occurs with a rebasing (like what happened above with your cherry-pick), you need to do a git rebase --continue instead of a git commit -c <BLAH>