git-review pushes in changes to draft changesets as published changesets
Bug #1172950 reported by
Ryan Lane
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
git-review |
New
|
Undecided
|
Unassigned |
Bug Description
When using git-review, if you are pushing into a changeset marked as draft and forget -D, it publishes the changeset. It should notice that it's pushing into a draft and push in a draft by default. Some folks use drafts for security changes, so this is pretty problematic.
(before you say you shouldn't use gerrit changes for security patches - it's OK if you split your viewer away from gerrit and you don't send notifications to anywhere public for drafts)
To post a comment you must log in.