Enforces "Topic" too strong (uses bug number mentioned in summary instead of branch name)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
git-review |
New
|
Undecided
|
Unassigned |
Bug Description
Upstreaming from https:/
Steps to reproduce:
1. Local checkout of mediawiki/core.git
2. git co -b 2012/foobar
3. (edit files)
4.
git commit; with a message that doesn't mention a bug number in the first 5
lines and somewhere a long the line it makes a mention of 3 bugs (not even in
parentheses), just like "foo bar bug 123, 456 (and bug 789 also)".
5. It will then have submitted it as topic: bug/123 instead of 2012/foobar.
---
I like the automatic topic but it should not happen if:
* I have a good local branch name already
* Did not mention the bug on the first line
* It wasn't the only bug mentioned
Workaround: Manually specify a topic on `git review`
What do you think should be the desired behaviour?
Currently it checks:
1) -t option (if yes, it uses that)
2) if local branch is named "review/%s/%s" then it uses the last string component
3) searches for bug or lp number
4) searches for blueprint ("bp") number
5) uses local branch name as it is
When checking out the change with "-d", local branch gets set to "review/ <author> /<change- number> " or "review/ <author> /<change- number> -patch< patchset- number> "