add an alias to option -d/--download as -e/--existing

Bug #1117894 reported by Waldir Pimenta on 2013-02-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
git-review
Invalid
Undecided
Unassigned

Bug Description

The -d/--download option is somewhat ambiguous. According to the current code at
https://github.com/openstack-infra/git-review/blob/ddcfafda07eff0e8a8acd64d7ae144011fd90e69/git-review#L853
that option is supposed to "download the contents of an existing gerrit review into a branch".

I think that typing "git review --existing 1234" is much more explicit about what the command does. I do realize, of course, that a breaking change such as renaming an option isn't likely feasible at this point, so instead I suggest this to be implemented as an alias, along with a change in the documentation to not mention -d as a supported option, but rather have a note in the -e option's documentation saying something like "(older versions used -d for this purpose)".

Cedric Brandily (cbrandily) wrote :

OpenStack users seem to be used to the -d option

==> Won't Fix ?

Waldir Pimenta (waldyrious) wrote :

"OpenStack users seem to be used to the -d option" -- how could they *not* be? that's the only choice currently available...

Note that I'm not suggesting renaming the option, merely providing an alias. That way no current users will be inconvenienced, and new users will have an easier time remembering this option.

Cedric Brandily (cbrandily) wrote :

-d/--download refers to what it does "downloading" a change (in opposition to uploading) like --compare to compate .. --existing seems more like a existence check

Changed in git-review:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers