change number is being used in topic

Bug #1064939 reported by Marcin Cieślak on 2012-10-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
git-review
Confirmed
Medium
Unassigned

Bug Description

Not sure how intentional is this, but some git-review'd changes tend to have "topic" set to the change number.
While it does not hurt much it is really strange when I tried "git-review" on a test gerrit repo not requiring Change-IDs.
The change was taken from branch "review/author/10", was submitted a new change "review/author/14" but the topic was set to "10".

James E. Blair (corvus) on 2012-12-14
Changed in git-review:
status: New → Triaged
importance: Undecided → Medium
Jeremy Stanley (fungi) wrote :

This is going to become more common now that 1.21 doesn't set a topic if the local branch name is the same as the remote branch (for example a developer working on master instead of in a topic branch). When you download a topic-less change with git review -d it will set the local topic branch name such that it ends with the change number. Any subsequent patchset or changes appended within that topic branch will get checked in with that change number as the new topic.

For me, this side effect of 2e27fad is unexpected, but I'm not convinced the behavior is necessarily disruptive (though I agree it has the potential to be somewhat misleading). I'm also not sure what a good fix would be for this--suggestions welcome.

Changed in git-review:
status: Triaged → Confirmed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers