git-review should be tested
Bug #1048724 reported by
Andrew Hutchings
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
git-review |
Fix Released
|
Medium
|
Dina Belova |
Bug Description
git-review currently does direct SSH access. We should instead use gerritlib. One main advantage of this is it makes mock based testing a lot easier.
Changed in git-review: | |
assignee: | nobody → matthew wagoner (matthew-wagoner) |
importance: | Undecided → High |
status: | New → Triaged |
summary: |
- git-review should use gerritlib + git-review should be tested |
Changed in git-review: | |
importance: | Low → Medium |
Changed in git-review: | |
assignee: | nobody → Jeremy Stanley (fungi) |
status: | Triaged → In Progress |
Changed in git-review: | |
assignee: | Jeremy Stanley (fungi) → Dina Belova (dbelova) |
Changed in git-review: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I'd say it's a long way to and not a very high priority:
1. gerritlib uses paramiko, which does not support SCP (yet) and we need this to install hook (but please see mine https:/ /github. com/saper/ simple- scp-client)
2. no value added as there is no support to HTTPS instead of SSH (as wished by some users here, see bug 1090118 or bug 1021073)