git review should support pushing directly as a WIP

Bug #1010469 reported by Thierry Carrez
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
git-review
In Progress
Wishlist
Unassigned

Bug Description

It could be useful to submit changes directly as a WIP since it would avoid triggering tests when we are 99% sure they would fail.

Example scenario:
You have a Nova change that requires a devstack change before it can pass. You can propose the devstack change and point to the WIP Nova change for more information on the upcoming Nova change that justifies modifying devstack. Submitting the Nova change normally would result, predictably, in failing useless tests until the devstack change is merged...

Could be implemented as -W the same way -D does Drafts.

Revision history for this message
Jeremy Stanley (fungi) wrote :

This feature appeared in 1.18 and was a casualty of "the big revert" known as 1.19. I'll see if I can forward-port it for inclusion in 1.22.

Changed in git-review:
status: New → Triaged
importance: Undecided → Wishlist
assignee: nobody → Jeremy Stanley (fungi)
Revision history for this message
Jeremy Stanley (fungi) wrote :

Actually it probably doesn't make sense to spend time on this until we know how the OpenStack project plans on accomplishing WIP in Gerrit 2.7 (whether we duplicate the current behavior or do something with a custom review status and Prolog to implement the control ACLs). If somebody really wants to re-add the -W option in git-review in the meantime though, I'm certainly not going to complain.

Changed in git-review:
assignee: Jeremy Stanley (fungi) → nobody
tags: added: low-hanging-fruit
Changed in git-review:
status: Triaged → In Progress
Changed in git-review:
assignee: nobody → Yuriy Taraday (yorik-sar)
Changed in git-review:
assignee: Yuriy Taraday (yorik-sar) → Stephen Finucane (sfinucan)
Revision history for this message
Jeremy Stanley (fungi) wrote :

Git review bugs are now tracked at storyboard.openstack.org, and this particular bug was migrated to https://storyboard.openstack.org/#!/story/1010469

Revision history for this message
Stephen Finucane (stephenfinucane) wrote :

Understood. It seems this bug has little purpose being here so, so I'm going to close it.

Changed in git-review:
assignee: Stephen Finucane (sfinucan) → nobody
Revision history for this message
Stephen Finucane (stephenfinucane) wrote :

Except I can't :) If you can, please do so

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.