Ginn should detect conflicting wishes

Bug #746756 reported by Gustavo Luiz Duarte
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
ginn
Triaged
Undecided
Bijan Binaee

Bug Description

Ginn should detect and warn the user when there are conflicting wishes.
For example, the current wishes.xml on repository contains 2 finger drag for scrolling globally and 2 finger drag for page up/down on firefox. If the user drags 2 fingers on device while using firefox both actions are triggered. It confuses a lot the user.

Related branches

Revision history for this message
Bijan Binaee (bijanbina) wrote :

the fix committed on related branch in this new code
just the first one run and the other not effect on gesture
the algorithm start from first wish and search to compatible gesture if find it do it and then stop search.

Changed in ginn:
status: New → Fix Committed
assignee: nobody → Bijan Binaee (bijanbina)
Revision history for this message
Bijan Binaee (bijanbina) wrote :

also for firefox you should change these wishes
    <wish gesture="Drag" fingers="2">
      <action name="action5" when="update">
        <trigger prop="delta y" min="20" max="80"/>
        <key>Page_Up</key>
      </action>
    </wish>
    <wish gesture="Drag" fingers="2">
      <action name="action6" when="update">
        <trigger prop="delta y" min="-80" max="-20"/>
        <key>Page_Down</key>
      </action>
to something like this
    <wish gesture="Drag" fingers="2">
      <action name="action5" when="update">
        <trigger prop="delta y" min="20" max="80"/>
        <button>4</button>
      </action>
    </wish>
    <wish gesture="Drag" fingers="2">
      <action name="action6" when="update">
        <trigger prop="delta y" min="-80" max="-20"/>
        <button>5</button>
      </action>
    </wish>

because page up and page down key move too fast!

Revision history for this message
Stephen M. Webb (bregma) wrote :

The proposed fix has been proposed but yet not been committed to the ginn project. Reverting status change.

Changed in ginn:
status: Fix Committed → Triaged
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.