TCP connections left in CLOSE_WAIT state after players disconnect from server

[cAPTAIN^k]

TCP connections left in CLOSE_WAIT state after players disconnect from server

These simply accumulate indefinitely until the program is exited

[cAPTAIN^k (k-old)]

I am running Windows 7 Professional 64bit

[MedO (smaxein)]

I wanted to tackle this bug right now, but for some reason I can't reproduce it anymore. Can you check again if it still happens for you?

[notagenericname (mlin4589)]

It happens to me

[notagenericname (mlin4589)]

okay I found the issue

while disconnecting the player using Player_Leave it uses remove player to get rid of it

however all it does is remove it from the list, and destroy the object.

directly using closesocket into removePlayer script should do it (untested, going to try right now)

[notagenericname (mlin4589)]

replace the removePlayer script with this
{
    closesocket(argument0.socket) // this is all I added
    with(argument0) {
        instance_destroy();
    }

    ds_list_delete(global.players, ds_list_find_index(global.players, argument0));
}

[notagenericname (mlin4589)]

also game server begin step the script concerning joining players
        if(sockstatus == 2) {
            closesocket(client)//all I changed
            with(joiningPlayer) {
                instance_destroy();
            }

[MedO (smaxein)]

closesocket is already called within the Destroy event of the Player object, so the change in removePlayer should make no difference. However, the suggestion for serverBeginStep looks good for fixing the problem. Thanks for your effort.

[MedO (smaxein)]

Actually, the second suggestion isn't the cause of the bug either. If nibbleMessage returns 2 it already closed the socket. I'm diving in some more to see if I can find other suspect places.

[MedO (smaxein)]

I rewrote the server-side player joining code completely now because it was horrible. Please try the version at http://ganggarrison.com/GG2_newconnectcode.zip and check if the problem is fixed.