Make gesturetest with no arguments Just Work

Bug #621600 reported by Mark Shuttleworth
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gesturetest
Won't Fix
Wishlist
Mohamed Amine Ilidrissi

Bug Description

Please can we make gesturetest default to assuming all gestures possible? Equivalent perhaps to gesturetest 0 0 0xffffffff

This way, we can just tell people "run gesturetest" and they'll see something useful, rather than remembering the magic flags and masks. This is important for those of us who cannot remember anything any more :-)

Related branches

Revision history for this message
Rafi (rafi-seas) wrote : Re: [Bug 621600] [NEW] Make gesturetest with no arguments Just Work

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/21/10 02:49, Mark Shuttleworth wrote:
> Public bug reported:
>
> Please can we make gesturetest default to assuming all gestures
> possible? Equivalent perhaps to gesturetest 0 0 0xffffffff

I've posted a branch at lp:~rafi-seas/+junk/utouch-gesturetest_no-args that
defaults to that (with a few more f's). Testing the normal package with those
parameters seems to work fine.

I can't seem to build from source. Are the build-deps or the source broken?
Anyway, I'd appreciate verification.

Rafi
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkxvnFEACgkQwuRiAT9o609MiQCgmfN5OgMtYRRyklLBeaA9J+GA
RYMAnjm2erbWnp+stfTu5xZDiD/rvCpG
=vn/0
-----END PGP SIGNATURE-----

Revision history for this message
Mark Shuttleworth (sabdfl) wrote :

 On 21/08/10 10:28, Rafi wrote:
> I've posted a branch at lp:~rafi-seas/+junk/utouch-gesturetest_no-args

Is there a utouch-gesturetest project on LP? If so, it should have a
trunk, and branches posted to that project
(~rafi-seas/utouch-gesturetest/foo) will be easier for others to find.

Mark

Revision history for this message
Mark Shuttleworth (sabdfl) wrote :

... and thanks for the patch, regardless of push location :-)

Revision history for this message
Rafi (rafi-seas) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/21/10 06:00, Mark Shuttleworth wrote:
> On 21/08/10 10:28, Rafi wrote:
>> I've posted a branch at lp:~rafi-seas/+junk/utouch-gesturetest_no-args
>
> Is there a utouch-gesturetest project on LP? If so, it should have a
> trunk, and branches posted to that project
> (~rafi-seas/utouch-gesturetest/foo) will be easier for others to find.
>
> Mark

Good to know. I haven't fully groked bzr and lp namespaces.

Thank you,
Rafi

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkxv4h8ACgkQwuRiAT9o608c2ACglhQBHfOMbgBF7S4+l+H/qrfC
8IoAn3K3YtnP7HbXGPaxzqBsoLsp/fRt
=1LgH
-----END PGP SIGNATURE-----

Revision history for this message
Duncan McGreggor (oubiwann) wrote :

Rafi,

We're creating branches with <ticket number>-<short description>. This is something that both Neil Patel and I use to great effect and at the Isle of Man sprint we decided to start doing for all ticket-based work (which will become the norm very shortly). Just in case it's not evident, just to this:

  bzr push lp:~rafi-seas/utouch-gesturestest/621600-no-args

Once you've pushed your branch to the utouch-gesturetest LP namespace, it will show up in code.launchpad.net/utouch-gesturetest, even though it's under ~rafi-seas.

Thanks!

d

Changed in utouch-gesturetest:
assignee: nobody → Rafi (rafi-seas)
importance: Undecided → Wishlist
Revision history for this message
Mohamed Amine Ilidrissi (ilidrissi.amine) wrote :

I created a new branch from Rafi's branch that fixes the bug once and for all, since the original code had compiler errors and didn't fix the bug. But you did a good job, Rafi :)

The merge proposal is here: https://code.edge.launchpad.net/~ilidrissi.amine/utouch-gesturetest/621600-no-args/+merge/36641

Changed in utouch-gesturetest:
status: New → In Progress
assignee: Rafi (rafi-seas) → Mohamed Amine IL Idrissi (ilidrissi.amine)
Revision history for this message
Mark Shuttleworth (sabdfl) wrote : Re: [Bug 621600] Re: Make gesturetest with no arguments Just Work

 \o/ :)

Revision history for this message
Mohamed Amine Ilidrissi (ilidrissi.amine) wrote :

A question: will that make it into 10.10, especially with the FinalFreeze? Or do we have to wait until 11.04?
Just asking :)

Revision history for this message
Chase Douglas (chasedouglas) wrote :

I'm sorry I haven't gotten back to this sooner, but I'm against this change. gesturetest is not a demo program that you run to see things fly across your screen when you perform gestures :). It's a test tool that must be used in specific ways to get the results you want to see.

For example, if you are interested in testing rotation gestures, you should subscribe only to them and not to other gestures. As soon as you start to listen for other gestures things get very confusing. It can be hard to understand why you might be receiving drag gestures when you perform a pivot rotation, and subscribing to all gestures by default only exacerbates the issue. Essentially, I don't want people to run gesturetest and make decisions based on poor testing scenarios.

Revision history for this message
Chase Douglas (chasedouglas) wrote :

Mohamed, aside from my disagreements on whether the patch should be applied, thanks a bunch for making the effort on this.

Revision history for this message
Mohamed Amine Ilidrissi (ilidrissi.amine) wrote :

@Chase: No problem, just don't forget to thank Rafi too :)
Aside from that, please see my comment on the merge proposal :)

Revision history for this message
Mark Shuttleworth (sabdfl) wrote :

Chase, I disagree, there's a valid use case in being able to eyeball the
full stream in the default case. I have often used it, and it's a pain
to have to remember the boilerplate. So, I'd ask the change is made. If
you'd like to think of ways the stream-of-data could be more useful,
that's a separate issue :-)

Mark

Revision history for this message
Duncan McGreggor (oubiwann) wrote :

Chase, I'm with Mark on this one. Regardless of the original intent of the tool, people will use it, and in ways that one doesn't expect. This cannot be controlled, and we should make it as easy to use as possible.

That being said, the misunderstanding that arise as a result can be addressed with education. Your concerns are best countered with an easy-to read Ubuntu wiki page in the Multitouch section. I've added a bug for that here: bug #649746.

Revision history for this message
Chase Douglas (chasedouglas) wrote :

I still disagree, but I'm in the minority and this isn't a huge deal. I'll merge the changes into gesturetest when I have a chance.

Revision history for this message
Chase Douglas (chasedouglas) wrote :

Gesturetest is obsolete. Closing bug.

Changed in utouch-gesturetest:
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.