In function _grail_be_slice_state_update position_y is not updated.

Bug #1477243 reported by gokhanettin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Geis
High
Stephen M. Webb
Trusty
High
Stephen M. Webb
Vivid
High
Stephen M. Webb
geis (Ubuntu)
High
Stephen M. Webb
Trusty
High
Stephen M. Webb
Vivid
High
Stephen M. Webb

Bug Description

static void
_grail_be_slice_state_update(struct _GeisSliceState *slice_state, UGSlice slice)
{

  if (slice_state->num_touches != grail_slice_get_num_touches(slice))
  {
    const UGTransform *C = grail_slice_get_cumulative_transform(slice);

    slice_state->angle = 0.0f;
    slice_state->position_x = grail_slice_get_original_center_x(slice) +
                              (*C)[0][2];
    slice_state->position_x = grail_slice_get_original_center_x(slice) +
                              (*C)[1][2];
    slice_state->radius = 1.0f;
    slice_state->num_touches = grail_slice_get_num_touches(slice);
  }
}

   slice_state->position_x = grail_slice_get_original_center_x(slice) +
                             (*C)[1][2];

I suspect this must be
   slice_state->position_y = grail_slice_get_original_center_y(slice) +
                             (*C)[1][2];

Related branches

Revision history for this message
Stephen M. Webb (bregma) wrote :

Eww. Nice catch.

Changed in geis:
importance: Undecided → High
milestone: none → 2.2.18
status: New → Triaged
Stephen M. Webb (bregma)
Changed in geis:
assignee: nobody → Stephen M. Webb (bregma)
Changed in geis (Ubuntu):
status: New → Triaged
importance: Undecided → High
assignee: nobody → Stephen M. Webb (bregma)
Changed in geis (Ubuntu Trusty):
importance: Undecided → High
status: New → Triaged
Changed in geis (Ubuntu Vivid):
status: New → Triaged
importance: Undecided → High
Changed in geis (Ubuntu Trusty):
assignee: nobody → Stephen M. Webb (bregma)
Changed in geis (Ubuntu Vivid):
assignee: nobody → Stephen M. Webb (bregma)
Changed in geis:
status: Triaged → In Progress
Changed in geis (Ubuntu):
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package geis - 2.2.17+15.10.20150728-0ubuntu1

---------------
geis (2.2.17+15.10.20150728-0ubuntu1) wily; urgency=medium

  [ Stephen M. Webb ]
  * Upstream release 2.2.17.
  * fix a pasto in the grail slice update code (LP: #1477243)

 -- CI Train Bot <email address hidden> Tue, 28 Jul 2015 21:11:00 +0000

Changed in geis (Ubuntu):
status: In Progress → Fix Released
Stephen M. Webb (bregma)
Changed in geis:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers