gschem: FTBFS with -Werror=format-security in CFLAGS

Bug #894400 reported by أحمد المحمودي (Ahmed El-Mahmoudy)
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gEDA
Fix Released
Undecided
Peter TB Brett

Bug Description

Recently, when I build geda-gaf 1.6.2 in Debian, I get the following error:

gcc -DLOCALEDIR=\"/usr/share/locale\" -DHAVE_CONFIG_H -I. -I../.. -I../../libgeda/include -I./../include -I../.. -I/usr/include -I../../intl -D_FORTIFY_SOURCE=2 -I/include -Wall -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -pthread -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/cairo -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -Werror=format-security -c -o gschem-gschem.o `test -f 'gschem.c' || echo './'`gschem.c
gschem.c: In function 'main_prog':
gschem.c:219:31: error: format not a string literal and no format arguments [-Werror=format-security]
gschem.c:221:5: error: format not a string literal and no format arguments [-Werror=format-security]
cc1: some warnings being treated as errors

A patch fixing this FTBFS is attached.

Revision history for this message
أحمد المحمودي (Ahmed El-Mahmoudy) (aelmahmoudy) wrote :
Revision history for this message
Peter TB Brett (peter-b) wrote :

This was previously fixed in commit 3f30ab76bbf247e8151fd4bbfd43bb7703e0fb80, which is included in the 1.7.x unstable releases.

Changed in geda:
assignee: nobody → Peter TB Brett (peter-b)
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.