Save errors don't bring up warning dialog

Bug #698566 reported by Peter Clifton
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
gEDA
Fix Released
High
Unassigned
geda-gschem (Debian)
Fix Released
Unknown

Bug Description

When saving a file which can't be writte, the error message dissapears quietly into the log window.

Since the user's data hasn't been saved, it would be appropriate to pop up a warning dialog citing the error and a standard description (from the OS) of why the file wasn't saved.

I've marked this as a gschem bug, although any dialogs added should be updated in gattrib as well.

When fixing this, it might be nice to update the logged messages. Currently, for a save error (due to permissions), we get:

o_save: Could not open [/home/pcjc2/geda/share/gEDA/sym/analog/resistor-2.sym]
Could NOT save page [/home/pcjc2/geda/share/gEDA/sym/analog/resistor-2.sym]

The first line is misleading, and should be removed. We should also cite the reason for the error after the second line.

Tags: gschem sf-bugs
Revision history for this message
Peter TB Brett (peter-b) wrote :

Steps to reproduce:

  mkdir unwritable
  touch unwritable/test.sch
  chmod -R a-w unwritable
  gschem unwritable/test.sch

Insert a component, "File->Save". No error message appears; log message is:

Can't save backup file: /home/peter/Projects/geda/gaf/unwritable/test.sch~.Could NOT save page [/home/peter/Projects/geda/gaf/unwritable/test.sch]

Changed in geda:
status: New → Triaged
Peter TB Brett (peter-b)
Changed in geda:
milestone: none → 1.8.0
Changed in pcb (Debian):
status: Unknown → Confirmed
Changed in geda:
status: Triaged → Fix Committed
Peter TB Brett (peter-b)
affects: pcb (Debian) → geda-gschem (Debian)
Peter TB Brett (peter-b)
Changed in geda:
status: Fix Committed → Fix Released
Changed in geda-gschem (Debian):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.