geda 1.10.0 fails to build

[أحمد المحمودي (Ahmed El-Mahmoudy)]

geda 1.10 fails to build, giving the following error:

x_controlfd.c: In function 'process_command':
x_controlfd.c:349:7: error: format not a string literal and no format arguments [-Werror=format-security]
  349 | fprintf (stderr, help_string);
      | ^~~~~~~
cc1: some warnings being treated as errors
make[5]: *** [Makefile:2248: gschem-x_controlfd.o] Error 1
make[5]: Leaving directory '/builds/electronics-team/geda-gaf/debian/output/geda-gaf-1.10.0/gschem/src'

Full build log can be found at: https://salsa.debian.org/electronics-team/geda-gaf/-/jobs/371123/raw

[Roland Lutz (rlutz)]

Thank you for reporting this.

This should have been a compiler warning, not an error, and consequently, it shouldn't have caused the build to fail. Have you added `-Werror' manually?

`help_string' is a string constant without conversion specifications, so it doesn't really matter if it is passed as a format string or argument. That said, the fix is trivial, so I applied it.

[Roland Lutz (rlutz)]

fixed in 10161a66271ed47c79e0fc12933ed436baec7ca7

[Roland Lutz (rlutz)]

fixed in gEDA/gaf 1.10.1