Undo hides images with relative filenames.

Bug #1523954 reported by Joshua Lansford
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gEDA
Triaged
Medium
Vladimir Zhbanov

Bug Description

If a schematic references a picture using a relative pathname so that the schematic is not tied into a single folder on everyone's system, then undo will temporarily drop the image until the schematic is re-opened. This is because undo opens a backup copy of the schematic saved in tmp and the relative images can not be found from this location. A patch is created which allows the real schematic path to be passed in as context when doing this undo. The tests have not been run for this patch.
This patch applies to git checkout 550f8136817fa0a5e0a240f058c8a7c73dd42520 pulled today.

Tags: image undo
Revision history for this message
Joshua Lansford (joshua-lansford) wrote :
Revision history for this message
Vladimir Zhbanov (vzhbanov) wrote : Re: [Bug 1523954] [NEW] Undo hides images with relative filenames.

Joshua,

Please try the attached patch.

Thanks,
  Vladimir

Changed in geda:
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Vladimir Zhbanov (vzhbanov)
milestone: none → 1.9.3
Revision history for this message
Joshua Lansford (joshua-lansford) wrote :

Vladimir,
  Thank you for responding to this bug report. The patch 1523954.diff prevents the picture from dumping, but unfortunately converts the path for the picture from relative to absolute next time the file is saved after an undo is used. If an absolute path where adequate in the file then the patch wouldn't be needed in the first place.
~Joshua

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.