Build failures on Mac OS X

Bug #1415312 reported by Alex Ray
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gEDA
Fix Released
Undecided
Edward Hennessy

Bug Description

On Mac OS X, there are a couple of build failures caused by the macro `g_return_if_fail` instead of `g_return_val_if_fail` in contexts that return non void types.

gschem_options_dialog.c:219:3: error: non-void function 'create_grid_mode_widget' should return a value [-Wreturn-type]
  g_return_if_fail (dialog != NULL);
  ^
/usr/local/Cellar/glib/2.42.1/include/glib-2.0/glib/gmessages.h:373:3: note: expanded from macro 'g_return_if_fail'
         return; \
         ^
gschem_options_dialog.c:342:3: error: non-void function 'create_snap_mode_widget' should return a value [-Wreturn-type]
  g_return_if_fail (dialog != NULL);
  ^
/usr/local/Cellar/glib/2.42.1/include/glib-2.0/glib/gmessages.h:373:3: note: expanded from macro 'g_return_if_fail'
         return; \
         ^
19 warnings and 2 errors generated.

Revision history for this message
Alex Ray (a-h2) wrote :

Patched the offending locations, attached patch.

Revision history for this message
Edward Hennessy (ehennes) wrote :

Alex, Thank you for the patch. -Ed

Changed in geda:
status: New → Fix Committed
assignee: nobody → Edward Hennessy (ehennes)
Changed in geda:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.