undo messes with the view even though undo panzoom is disabled

Bug #1367462 reported by KaiMartin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gEDA
Fix Released
Undecided
Unassigned

Bug Description

By default, gschem undo includes pan and zoom into its undo cache. That is, it backsteps the views on undo. This is mildly annoying and very unusual, to say the least. I know no other graphics application that does this.

I understand the intention - get the view to where the undo action is. However, it does not work for me. Either I know very well what is going to be undone because I did it seconds before. Or the actual does not catch my attention because I find myself at some unexpected spot.

There is an option in system-gschemrc that seems like it should switch off undo of zoom and pan. So I put this line in my gschemrc:

    (undo-panzoom "disabled")

But gschem still sometimes changes the view when I hit [u] to undo an edit.

Suggestion:
   1) Disable undo-panzoom by default.
   2) Make sure that no pan or zoom is undone when undo-panzoom is disabled.

---<)kaimartin(>---

Tags: gschem ui
description: updated
Revision history for this message
Bert Timmerman (bert-timmerman) wrote :

Hi,

FWIW:

From an "electrical" point of view including the zoom operations in "undo/redo" may not be necessary.

OTOH, the"principle of least surprise" for users is a point to consider as well.

I for one like to see every step in the "undo/redo" sequence, even if the electrical functionality of the schematic does not change in a zoom undo/redo operation.

However if undo-panzoom is set "disabled", gschem should play nice and consistent, if not, please file a bug report.

I would go for suggestion 2.

Kind regards,

Bert Timmerman.

P.S. IIRC, AutoCAD does.

Revision history for this message
Roland Lutz (rlutz) wrote :

fixed in 1f5de2868e49692a0538728306ea92549936472f

Changed in geda:
status: New → Fix Committed
Revision history for this message
Roland Lutz (rlutz) wrote :

released in gEDA/gaf 1.10.0

Changed in geda:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.