broken verilog bufif symbols

Bug #1304681 reported by Alex-Daniel Jakimenko on 2014-04-08
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

I have found a bug with verilog symbols bufif1-1.sym and bufif0-1.sym. For some reason gnetlist is not respecting the pinseq order, so the way they appear in the parameter list is determined by the order in .sym file, which is wrong currently:

When it should be:

This leads to broken simulations.

I have attached a patch to fix this issue.

Vladimir Zhbanov (vzhbanov) wrote :

Hi, Alex.
Could you provide a link to any document which can confirm the
order of pins you've used for these symbols is right?


Vladimir Zhbanov (vzhbanov) wrote :

I mean, of course the order in the resulting netlist.
8.0 Primitive Instances (Page 19)
bufif0, bufif1, notif0, notif1 - (1–output, 1–input, 1–control)

You can also look at pinseq number, which confirms it as well.

I'm glad you asked it, because I've just noticed that notif symbols are wrong as well.

I am attaching one more patch to fix notif symbols.

Changed in geda:
status: New → Confirmed

Bug was fixed by a commit
git master commit 3f0987e69b1736a96977966f6a3eec72cfa7fe1d

commit 3f0987e69b1736a96977966f6a3eec72cfa7fe1d
Author: Alex Jakimenko <email address hidden>
Commit: Vladimir Zhbanov <email address hidden>

    gnetlist: fixed pin order of notif verilog symbols

    Closes-bug: lp-1304681

Changed in geda:
status: Confirmed → Fix Committed

A commit was made which affects this bug
git master commit b7f86664c70ddc920c0055841fed55aee4aa730b

commit b7f86664c70ddc920c0055841fed55aee4aa730b
Author: Alex Jakimenko <email address hidden>
Commit: Vladimir Zhbanov <email address hidden>

    gnetlist: fixed two bufif symbols

    As the gnetlist verilog backend does not respect pinseq numbers, this
    results in a wrong parameter order inside produced verilog files.

    Affects-bug: lp-1304681

Changed in geda:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers