Wrong parameter order in lists returned by object-fill
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
gEDA |
Fix Released
|
Undecided
|
Peter TB Brett |
Bug Description
Currently, the object-fill function returns each angle parameters
after the corresponding pitch parameter in the list it outputs,
i.e. in a reverse order in comparison with what the file
format specification and geda-scheme.info say, and what gschem
actually outputs.
So "(caddr (object-fill box))" returns a pitch and
"(cadddr (object-fill box))" returns an angle.
The attached patch fixes this changing the order of these
parameters to the proper one.
The reason I put it here and don't commit it directly to the
repository is that there is a chance somebody uses this function
in his/her scripts, and I'm in doubt, whether we should support
bug-for-bug compatibility with previous versions or fix this.
Changed in geda: | |
assignee: | nobody → Peter TB Brett (peter-b) |
Changed in geda: | |
status: | New → In Progress |
Changed in geda: | |
status: | In Progress → Fix Committed |
Changed in geda: | |
milestone: | none → 1.9.1 |
Changed in geda: | |
status: | Fix Committed → Fix Released |
Hi Vladimir,
If set-object-fill! and object-fill are consistent (they appear to be), I think the correct thing to do is to preserve API compatibility and to update the documentation.
Thanks,
Peter