undocumented "feature" in spice-sdb

[Vladimir Zhbanov]

The "spice-sdb" backend for gnetlist has an undocumented feature
which I consider a bug since it adds unnecessary complexity and
ambiguity to the code. This feature consists in the possibility of
using the "value=" attribute instead of the "file=" attribute only
in the case when the include block symbol is used and only in
embedding mode (with '-O embedd_mode' flag). An example of
potentially possible problems can be found in bug 1258834. The
documentation on the spice-sdb backend
(http://wiki.geda-project.org/geda:csygas) does not allow such
include block using (see the table 1 below).
So I propose to eliminate the only case of using "value=" instead
of "file=". Attached is a patch against the current git master
head (ee58e97) which does just this.

[Peter TB Brett (peter-b)]

Hi Vladimir,

Backwards-incompatible change in behaviour should probably have an entry in NEWS associated with it. Otherwise, I'm happy with this approach.

Thanks,

Peter

[Vladimir Zhbanov (vzhbanov)]

Fixed in commit 768d0f7.