Deleting objects does not set page changed flag

Bug #1081798 reported by Peter TB Brett
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
gEDA
Fix Released
High
Unassigned

Bug Description

Deleting objects in gschem does not set the page changed flag.

Steps to reproduce:

1) `gschem foo.sch' (any non-empty schematic will do)
2) Delete anything.
3) File->Quit

Expected behaviour:

- Prompted to save unsaved changes

Actual behaviour:

- gschem quits immediately

Affects 'master' and 'stable-1.8'.

Tags: gschem
Peter TB Brett (peter-b)
Changed in geda:
assignee: nobody → Peter TB Brett (peter-b)
Peter TB Brett (peter-b)
Changed in geda:
assignee: Peter TB Brett (peter-b) → nobody
Revision history for this message
Matt (angst7) wrote :

It looks like this is just an oversight in o_delete.c. Attaching a one-liner patch that fixes it for me against the latest source.

Revision history for this message
gpleda.org commit robot (gpleda-launchpad-robot) wrote :

Bug was fixed by a commit
git master commit f1a7943d2e0f66bd174ad09796ce0ad8dbf748ca
http://git.geda-project.org/geda-gaf/commit/?id=f1a7943d2e0f66bd174ad09796ce0ad8dbf748ca

commit f1a7943d2e0f66bd174ad09796ce0ad8dbf748ca
Author: Vladimir Zhbanov <email address hidden>
Commit: Vladimir Zhbanov <email address hidden>

    gschem: set the page changed flag in o_delete_selected

    Closes-bug: lp-1081798

Changed in geda:
status: New → Fix Committed
Revision history for this message
Vladimir Zhbanov (vzhbanov) wrote :

Matt,
Thank you for your patch.
Please, next time you'll make a patch, do it using the 'git format-patch' command.

Vladimir

Changed in geda:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.