Geary should use Granite

Bug #1074483 reported by Mario Guerriero
24
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Geary
Confirmed
Undecided
Unassigned

Bug Description

Geary should be, almost in elementary OS, should use Granite for a reason of consistency between the whole OS. It is a bit ugly to see a Gtk.AboutDialog or to not see an AppMenu in one of our default apps.

Revision history for this message
Cody Garver (codygarver) wrote :

It does use Granite for the sidebar handle, but not for About. Right now I'm looking for kalikiana to adjust its CMakeLists.txt on yorba's repo so that it properly detects Granite.

David Gomes (davidgomes)
affects: elementaryos → geary
Revision history for this message
Jim Nelson (yorba-jim) wrote :

Before proceeding, I'd like to know what components need to be changed to support Granite.

Jim Nelson (yorba-jim)
Changed in geary:
status: New → Incomplete
Revision history for this message
Ender (luksireiku) wrote :

-When started for the first time, it needs to show a dialog to input the email, password etc. It needs to use the Welcome Screen widget of Granite.
-And the about dialog needs to use the About Dialog widget.
-For some reason the toolbar buttons have too much padding, I attached a screenshot.

Revision history for this message
Jim Nelson (yorba-jim) wrote :

- The toolbar problem is known and ticketed: http://redmine.yorba.org/issues/5866

- Does the Granite Welcome Screen include a way to ask for the account information, or are you saying the Welcome Screen is shown first, and then the dialog asking for account information?

- This is the doc I found for Granite's About Box: http://valadoc.elementaryos.org/Granite/Granite.GtkPatch.AboutDialog.html Is this the latest? If so, this doesn't look too bad, as it's almost the same as GTK's.

I'm probably going to ticket up each to-do into a separate ticket on our Redmine system (unless you want to do so: http://redmine.yorba.org), so if there's anything else we would need to do for this, please let me know. In a nutshell, the smaller the change required to support Granite, the more likely it'll go in sooner rather than later (unless, of course, someone shows up with a solid patch).

Revision history for this message
Ender (luksireiku) wrote :

-In my opinion, the Welcome screen is shown first, diaplaying a list of supported '¿services?' you know.. Gmail, Hotmail, Yahoo etc. and when one is clicked is shows the dialog.
Read the HIG of the Welcome Screen or ask Daniel Fore.
Welcome Screen: http://elementaryos.org/docs/human-interface-guidelines/ui-toolkit-elements/welcome-screen

-I'm not a developer so I don't know if the documentation is the latest, but I attach a screenshot showing the About Dialog of pantheon-terminal

Jim Nelson (yorba-jim)
Changed in geary:
status: Incomplete → Confirmed
Revision history for this message
Jim Nelson (yorba-jim) wrote :

I've made a meta-ticket for all Granite work on our Redmine server: http://redmine.yorba.org/issues/6088 Individual tasks (such as the About Box) are linked to that ticket.

Revision history for this message
Jim Nelson (yorba-jim) wrote :

One of our users has noted that the GtkInfoBar in Files looks different than the GtkInfoBar in other apps (including Geary): http://redmine.yorba.org/issues/6105 Is this a specialty Granite widget or something else that Geary should do to work well under Elementary?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers