inform worker about failed job_done if persistent db is down

[surajs sharma]

Hi,

Setup:
I am running gearmand with mysql as a persistent queue.

Scene:
When the job is picked by a worker and just before worker doing a job done, the mysql goes down.
Now, if worker fire a job done, gearmand will fail to remove it from mysql and as a result of this it will stay in its internal memory queue. Now the problem here is that, worker is not informed about such failure on job done. No ERROR packet is transmitted back to the worker.

Refer line: https://github.com/dm/gearmand/blob/master/libgearman-server/server.cc#L836

at this line we should add the below code -
return _server_error_packet(GEARMAN_DEFAULT_LOG_PARAM, server_con, GEARMAN_QUEUE_ERROR, gearmand_strerror(ret), strlen(gearmand_strerror(ret)));

Let me know if i am missing something.

Regards,
Suraj Sharma